New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release liquibase-cdi-jakarta to maven repositories #4001
Release liquibase-cdi-jakarta to maven repositories #4001
Conversation
Initial/Pre-Review Thoughts Thanks for the updates to the release logic. Questions I have:
Potential risks:
What could make the full review difficult:
|
Hi @nvoxland, thanks for the review.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In 4.20.0 we added the new module. Now we need to release it, thanks for the PR @DCCSKrezovic !
hi, @filipelautert! The liquibase-artifacts.zip from this PR's build do not contain the renamed CDI. Is that expected? |
|
||
cp liquibase-cdi-jakarta/target/liquibase-cdi-jakarta-0-SNAPSHOT.jar artifacts | ||
cp liquibase-cdi-jakarta/target/liquibase-cdi-jakarta-0-SNAPSHOT-sources.jar artifacts | ||
cp liquibase-cdi-jakarta/target/liquibase-cdi-jakarta-0-SNAPSHOT-javadoc.jar artifacts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @XDelphiGrl - the copy commands are here , but as we execute the scripts from master they will only run when this pr is merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the explanation, @filipelautert. I'll go ahead and do my code review and we can get this merged. I'll check that the build produces the correctly named artifacts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming soon to a Maven near you ... liquibase-cdi-jakarta! This PR updates build logic to for the CDI artifacts. The sign-artifacts.sh script generates the MD5 and SHA1at the directory level; the renamed CDI artifacts will go through the same signing process as the previous CDI artifacts.
- The functionality of these build changes cannot be validated until they are merged to master.
- QA will check the generated artifacts from the concomitant master build for correctness.
- Test harness and functional tests do not exercise CDI; results unnecessary.
APPROVED
Impact
Description
This updates the github actions to include the newly added liquibase-cdi-jakarta module.
Fixes #3962