New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes the stream output of liquibase when success message #611

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@Alexandre-Machado

Alexandre-Machado commented Oct 8, 2016

On Octopus Deploy, the stream is used for the status of the deploy:

System.err.println
image

System.out.println
image

@hkdennis2k

This comment has been minimized.

Show comment
Hide comment
@hkdennis2k

hkdennis2k Oct 11, 2016

I think System.err fit for most cases.

If the patch was just for Octopus Deploy, may be a configuration or integration module does better than change everyone else?

hkdennis2k commented Oct 11, 2016

I think System.err fit for most cases.

If the patch was just for Octopus Deploy, may be a configuration or integration module does better than change everyone else?

@kaltinril

This comment has been minimized.

Show comment
Hide comment
@kaltinril

kaltinril Dec 15, 2016

I agree with @Alexandre-Machado , the only thing that should go to stderr are errors.

We have a bamboo process that I was investigating when I stumbled across main.java and this issue. Atlassian Bamboo reports every line from the liquibase deployment as an "error" because the output is on the stderr stream.

Why would you want success messages going to the error stream?

kaltinril commented Dec 15, 2016

I agree with @Alexandre-Machado , the only thing that should go to stderr are errors.

We have a bamboo process that I was investigating when I stumbled across main.java and this issue. Atlassian Bamboo reports every line from the liquibase deployment as an "error" because the output is on the stderr stream.

Why would you want success messages going to the error stream?

@Alexandre-Machado

This comment has been minimized.

Show comment
Hide comment
@Alexandre-Machado

Alexandre-Machado Jun 29, 2017

Related issues

  • CORE-2913: Shell script prints to stderr on success

Alexandre-Machado commented Jun 29, 2017

Related issues

  • CORE-2913: Shell script prints to stderr on success
@gytisgreitai

This comment has been minimized.

Show comment
Hide comment
@gytisgreitai

gytisgreitai Jul 21, 2017

this just hit us too. Stackdriver shows these as errors, so we cannot create an alert if liquibase actually failed.

Since this has been sitting here since October, as I understand there is no intention to merge this?

gytisgreitai commented Jul 21, 2017

this just hit us too. Stackdriver shows these as errors, so we cannot create an alert if liquibase actually failed.

Since this has been sitting here since October, as I understand there is no intention to merge this?

@Alexandre-Machado

This comment has been minimized.

Show comment
Hide comment
@Alexandre-Machado

Alexandre-Machado Oct 11, 2017

closing commit because now it does not make sense anymore

Alexandre-Machado commented Oct 11, 2017

closing commit because now it does not make sense anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment