Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix CORE-3455 + CORE-3555 load[Update]Data/column@defaultValue[XXX] was not used #964
…om the DB if not all columns are declared in the change - Fix CORE-3555 loadData[Update]/column@defaultValue[XXX] was not used. It works for EMPTY cells (Ones with "NULL" are still inserted as NULL) - Fix: NullPointerException in LoadDataChange if "header" was used for not existing column - Fix: loadData[Update]@file, loadData[Update]@tableName, column@name not only required, it musn't be empty - XSD changes: coulmn.name, loadData.tableName, loadData.file made required, nonEmptyString
- Empty property check added to generate different error if required property is set to empty or whitespace only resulting errors like "tableName is empty for loadData" instead of SQL error like: "Could not snapshot table 'PUBLIC.' to get the missing column type information. ... Error: Syntax error in SQL statement "MERGE INTO PUBLIC. ([*]A, B) KEY() VALUES ('a', '1');"; expected "identifier"; ... Change implemented in ChangeWithColumns to easily use it in other places like createTable, addColumn
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.