Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CORE-3455 + CORE-3555 load[Update]Data/column@defaultValue[XXX] was not used #964

Open
wants to merge 4 commits into
base: 3.8.x
from

Conversation

@b-gyula
Copy link

b-gyula commented Jan 11, 2020

  • Fix CORE-3455 load[Update]Data Get all column's missing type information from the DB even if columns are declared in the change
  • Fix CORE-3555 load[Update]Data/column@defaultValue[XXX] was not used. It works for EMPTY cells (Ones with "NULL" are still inserted as NULL)
  • Fix: NullPointerException in LoadDataChange if "header" was used for not existing column
  • Fix: load[Update]Data@file, load[Update]Data@tableName, column@name not only required, it mustn't be empty to avoid cryptic SQL errors
  • XSD changes: column.name, loadData.tableName, loadData.file made required, nonEmptyString
  • Fix CORE-3554 load[Update]Data treated values differently depending if column type is defined
b-gyula added 3 commits Jan 9, 2020
Mergeback
…om the DB if not all columns are declared in the change

- Fix CORE-3555 loadData[Update]/column@defaultValue[XXX] was not used. It works for EMPTY cells (Ones with "NULL" are still inserted as NULL)
- Fix: NullPointerException in LoadDataChange if "header" was used for not existing column
- Fix: loadData[Update]@file, loadData[Update]@tableName, column@name not only required, it musn't be empty
- XSD changes: coulmn.name, loadData.tableName, loadData.file made required, nonEmptyString
- Empty property check added to generate different error if required property is set to empty or whitespace only resulting errors like "tableName is empty for loadData" instead of SQL error like:
    "Could not snapshot table 'PUBLIC.' to get the missing column type information. ...
    Error: Syntax error in SQL statement "MERGE INTO PUBLIC. ([*]A, B) KEY() VALUES ('a', '1');"; expected "identifier"; ...
Change implemented in ChangeWithColumns to easily use it in other places like createTable, addColumn
@b-gyula b-gyula changed the title Fix CORE-3455 + CORE-3555 loadData[Update]/column@defaultValue[XXX] was not used Fix CORE-3455 + CORE-3555 load[Update]Data/column@defaultValue[XXX] was not used Jan 12, 2020
…ng without spaces

- load[Update]Data/column: only used attributes allowed
- load[Update]Data@type restricted to only accepted values
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.