This repository was archived by the owner on Jun 15, 2022. It is now read-only.
Cleanup the table installation script #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re simple getters that were used exactly once.
…hods. This keeps us from creating an instance of a WC_Custom_Order_Table_Install (as it's really only a pseudo-namespace, not an actual object). This change also enables us to drop the wc_custom_order_table_install() function, since we can call the `activate()` method directly.
Based on https://developer.wordpress.org/reference/classes/wpdb/has_cap/#source, MySQL has supported collation since version 4.1, which is *far* below the minimum MySQL requirements for WordPress (5.0+, per https://wordpress.org/about/requirements/).
bswatson
approved these changes
Dec 23, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the
WC_Custom_Order_Table_Installto use just two static methods:activate()(which performs the jobs formerly handled bymaybe_install_tables(),get_latest_table_version(), andget_installed_table_version()), andinstall_tables(), the latter of which is marked as protected.This enables
register_activation_hook()to callWC_Custom_Order_Table_Install::activate()directly, while avoiding treating the installer as an object (since it's really just using the class construct as a pseudo-namespace).The PR also ensures that the "wc_orders_table_version" option is not auto-loaded, as it's only needed during plugin activation.