Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probable fix for issue #26 #27

Merged
merged 3 commits into from Aug 31, 2020
Merged

Probable fix for issue #26 #27

merged 3 commits into from Aug 31, 2020

Conversation

pmonks
Copy link
Contributor

@pmonks pmonks commented Aug 31, 2020

Probable (untested) fix for issue #26. Please note that I haven't deployed the resulting container to Dockerhub, so this fix should not be considered "tested".

Copy link
Owner

@liquidz liquidz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmonks Ah, sorry for that.
I tested in my local environment, and works well.

Could you change the only point I suggested?

Dockerfile Outdated Show resolved Hide resolved
Remove apt droppings, to keep the container as lean as possible.

Co-authored-by: Iizuka Masashi <liquidz.uo@gmail.com>
@pmonks
Copy link
Contributor Author

pmonks commented Aug 31, 2020

No worries - I'm just sorry I didn't catch this myself!

@liquidz liquidz merged commit de1d365 into liquidz:dev Aug 31, 2020
@liquidz
Copy link
Owner

liquidz commented Aug 31, 2020

Thank you so much!
I'll deploy to dockerhub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants