Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan errors out with PROTOCOL_TIMEOUT #73

Closed
Ryuno-Ki opened this issue Jul 16, 2020 · 4 comments · Fixed by #75
Closed

Scan errors out with PROTOCOL_TIMEOUT #73

Ryuno-Ki opened this issue Jul 16, 2020 · 4 comments · Fixed by #75
Assignees
Labels
bug Something isn't working good first issue Good for newcomers released

Comments

@Ryuno-Ki
Copy link
Collaborator

On Ubuntu in a corporate network
When I scan my employer's homepage (https://jambit.com/)
AND I turn DEBUG=* on,
Then I can see a start of the audit:

const scanResult = await lighthouse(url, opts, {
extends: 'lighthouse:default',
settings: this.settings
})

And a timeout with PROTOCOL_TIMEOUT after a while (30 seconds?).

This does not happen when running the code
npx is-website-vulnerable https://jambit.com/ from home.

Looks like it were caused by GoogleChrome/lighthouse#6512 but this npm package might need to handle the error gracefully.

I haven't took time to clone the repo and run a local build.

@lirantal lirantal added bug Something isn't working good first issue Good for newcomers labels Jul 16, 2020
@lirantal
Copy link
Owner

Thanks @Ryuno-Ki for the detailed report 👍
Indeed I think we just need to detect and gracefully handle with a descriptive error message

@rajkumaar23
Copy link
Contributor

Can I take this up? @lirantal

@lirantal
Copy link
Owner

lirantal commented Aug 6, 2020

@rajkumaar23 definitely, thank you ❤️

@github-actions
Copy link

github-actions bot commented Aug 8, 2020

🎉 This issue has been resolved in version 1.14.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants