Fix argmax call in logreg tutorial docs to include axis=1. #15

Merged
merged 1 commit into from Jan 11, 2013

2 participants

@fbreuer

There is one little error in the text, which led to a very subtle bug, that I just a significant amount of time hunting done. In the first code listing on that page, the second to last code line needs to read:

y_pred = T.argmax(p_y_given_x, axis=1)

instead of

y_pred = T.argmax(p_y_given_x)

As far as I understand it, these lines used to be equivalent in a previous version of Theano, but now they are different significantly different. (At first glance, the code appears to run just fine, though.)

@lamblin
Laboratoire d’Informatique des Systèmes Adaptatifs member

Thanks for the fix! Apparently, it had been applied in the code itself (code/logistic_sgd.py), but not in the documentation.
Travis failure is unrelated.

@lamblin lamblin merged commit 400c637 into lisa-lab:master Jan 11, 2013

1 check failed

Details default The Travis build failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment