Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Basic SSL support #7

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

st1gma commented Dec 13, 2012

API was moved to SSL only now so doing HTTP calls end up in redirects that the library does not know how to handle. I have moved it to do the HTTPS calls instead now.

TODO: Properly check the certificate of the API site.

@dhiemstra dhiemstra commented on the diff Jan 1, 2013

lib/reve.rb
@@ -1109,6 +1109,8 @@ def get_xml(source,opts)
# ||= to prevent making a new Net::HTTP object, the res = nil above should reset this for the next request.
# the request needs to be here to rescue exceptions from it.
http ||= Net::HTTP.new(source.host, source.port)
+ http.use_ssl = true
@dhiemstra

dhiemstra Jan 1, 2013

I would suggest to do a check here if the schema is https. Reasoning is that this method also supports "custom" url's.
Maybe something like if source.scheme == 'https'

+1 for this.

Collaborator

fmorales commented Dec 22, 2013

Closing this pull request because the code was pulled into the fmorales branch downstream, and merged back upstream in the rollup

@fmorales fmorales closed this Dec 22, 2013

st1gma commented Dec 22, 2013

Cool! I thought this was dead. I believe the api has changed significantly
since..
On Dec 21, 2013 5:20 PM, "Frances Morales" notifications@github.com wrote:

Closed #7 #7.


Reply to this email directly or view it on GitHubhttps://github.com/lisa/reve/pull/7
.

Collaborator

fmorales commented Dec 22, 2013

Nope, it's not dead. I've been working on it pretty actively in my fork. I'll be pushing upstream when things get to good push points.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment