Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

Merge branch 'master' of github.com:lisasoft/gt-rnd

  • Loading branch information...
commit 254dd42bd5c345f5d93d32a7cfaff73183aeaf8d 2 parents ec8df60 + ddf0d27
scotthendo scotthendo authored
90 prototype/face/README.txt → prototype/face/README.textile
View
@@ -6,12 +6,7 @@ To build this project (or even load it in your IDE) you will need:
- Maven 2.2.1 or newer
- Eclipse 3.6 or newer
-HOW TO RUN COMMAND LINE
-
-0. mvn install
-1. mvn exec:java -Dexec.mainClass="com.lisasoft.face.Prototype"
-
-HOW TO RUN ECLIPSE
+h2. How to Run in Eclipse
1 From the command line:
@@ -33,41 +28,41 @@ HOW TO RUN ECLIPSE
4. Right click on "Prototype" and run as a Java application
+h2. Assesment of Prototype
-h2. Tasks
+The prototype was procduced promptly with a small team; documenation for the GeoTools library
+was good; even for this "unsupported" gt-swing module. This is helped by the fact that the
+gt-swing code is used in all the tutorials.
-1. JG: DuplicatingStyleVisitor needed to make relative icon references be absolute
- (alternatives listed below) but this one we can perform in our application. See examples
- in geotools docs; should be a class with one method overriden to peform the transformation.
- similar to XSLT but for object data strutures.
- This is used to allow the correct Icon for "Face" display.
- Note the style can also use a Label (in blue) and a line from the point location to the label
- offset. This line can be drawn with a line symbolizer using a geometry function (rather than
- just a propertyName reference).
-2. JG: Review requirements for supported status with mbedward (see below)
-3. JG: Go over assessment of this solution/approach
+The prototype illustrates how to remap a java bean as a "Feature" for display. Feature are literally
+a feature of map that are drawn. This work took one day and proceeded smoothly; the only wrinkle was
+changing styles over to use the Java Bean wrapper; as some of the property names had changed names
+from the origional sample data.
-h2. Feedback on gt-swing
+The GeoTools styling system is more than capable showing great rendering performance.
-The following issues were identified that made coding more verbose than needed:
+The simulated data access object was sufficent to run the prototype but did not explore fully
+the kind of notifcations and queries required to work with large amounts of data. In particular
+a bounding box based query would be useful evaulation point when hooking up to a proper OR mapper.
-* Unable to smoothly ask the map to redraw itself in response to selection changes; since we do
- not have a layer list this was difficult. The JMapComponent needs a method to accept
- MapChangedEvents and trigger the appropriate redraw activity.
- (This was actually amsuing as we would call JComponent.repaint() and get the same map generated
- as the component draws into a back buffer).
-* MapMouseEvent ReferencedEnvelope based on number of pixels: https://jira.codehaus.org/browse/GEOT-3715
- Update this issue has been closed (2 day response time).
+The tool API was easy to follow with clear seperation of concerns; we would like a better technque
+then changing the cursor in order to provide visual feedback during editing. This is best
+accomplished using the Swing glass pane layer; or by adding the concept of a transparent
+layer to the JMapPane component.
-* Relative paths for ExternalGraphics (ie Icon references) is not well supported
-
- Options (these are alternaitves):
-
- - Preprocess Style using a visior to rewrite relativ paths
- - Update ImageGraphicFactory or SLDStyleFactory to handle relative file paths
- - Use env vairable subst: so ${base}/face.png would refer to the SLD document base
+The JMapComponent renderings as single buffered image in a background thread; we woudl prefer
+to control the number of images produced; in order to isolate "base map" data from the layer
+comprising the buisness objects. This would allow the map to redraw with out flickering.
-Required work:
+We recommend this approach based on our knowledge of your development team; it would be good
+to evaulate the intergration of this component with your existing work in order to focus
+on any performance or notification concerns.
+
+We wish AGP the best of luck with their continued development.
+
+h2. Feedback on gt-swing
+
+Required work to make gt-swing supported:
* MapContext is deprecated; the adption to use the MapContent is progressing as we speak
on trunk showing active maintence of the library by the module maintainer.
@@ -82,9 +77,6 @@ Required work:
* Test case coverage is low; may be able to make the argument that the coverage by the tutorial
code is more than sufficient to keep the API stable
-
-* Small trouble sharing data between base map and selection layer
- https://jira.codehaus.org/browse/GEOT-3716
* JMapPane handles a single background MapContent; it would be good to use a second BufferedImage
for draw quick feedback on (such as feedback from tools).
@@ -92,4 +84,26 @@ Required work:
* Ability to change the icons for the Actions would be nice; this is a low priority
-* The name JMapPane actually caused real confusion; because it extends JPanel :-)
+Trvial feedback (raised as issues in the issue tracker):
+The following issues were identified that made coding more verbose than needed:
+
+* Unable to smoothly ask the map to redraw itself in response to selection changes; since we do
+ not have a layer list this was difficult. The JMapComponent needs a method to accept
+ MapChangedEvents and trigger the appropriate redraw activity.
+ (This was actually amsuing as we would call JComponent.repaint() and get the same map generated
+ as the component draws into a back buffer).
+
+* MapMouseEvent ReferencedEnvelope based on number of pixels: https://jira.codehaus.org/browse/GEOT-3715
+ Update this issue has been closed (2 day response time).
+
+* Relative paths for ExternalGraphics (ie Icon references) is not well supported
+
+ Options (these are alternaitves):
+
+ - Preprocess Style using a visior to rewrite relativ paths
+ - Update ImageGraphicFactory or SLDStyleFactory to handle relative file paths
+ - Use env vairable subst: so ${base}/face.png would refer to the SLD document base
+
+* Small trouble sharing data between base map and selection layer
+ https://jira.codehaus.org/browse/GEOT-3716
+
6 prototype/face/src/main/java/com/lisasoft/face/table/FaceTableModel.java
View
@@ -204,9 +204,9 @@ public void setValueAt(Object value, int row, int col) {
editface.setSuedNordKoordinate(new BigDecimal(String.valueOf(value)));
}
- cache.clear();
- load = new TableWorker(faces);
- load.run();
+// cache.clear();
+// load = new TableWorker(faces);
+// load.run();
this.fireTableDataChanged();
1  prototype/face/src/main/java/com/lisasoft/face/tool/PointDragTool.java
View
@@ -93,7 +93,6 @@ public void onMouseReleased(MapMouseEvent ev) {
mapPane.setSelectionWithoutHighlighting(list);
oldFace.setCoords(new BigDecimal(dropped.x), new BigDecimal(dropped.y));
-
}
/**
Please sign in to comment.
Something went wrong with that request. Please try again.