Skip to content

/ groupie

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion - rename ViewHolder classes to GroupieViewHolder #287

Closed
ValCanBuild opened this issue Sep 17, 2019 · 5 comments
Closed

Discussion - rename ViewHolder classes to GroupieViewHolder #287

ValCanBuild opened this issue Sep 17, 2019 · 5 comments
Labels
question

Comments

@ValCanBuild
Copy link
Collaborator

@ValCanBuild ValCanBuild commented Sep 17, 2019 •
edited

I'd like to start making more quality of life improvements in the library. One thing that I find annoying as a user is the fact that the Groupie ViewHolder class shares a name with the actual platform one.

My proposal is to rename it GroupieViewHolder. Ideally I'd also like to rename the databinding and kotlin-android-extensions versions to something else as well but I don't have any great name ideas. Would anyone have any suggestions?

Please comment here with your thoughts on this.
@Zhuinden
Copy link
Collaborator

@Zhuinden Zhuinden commented Sep 17, 2019

My typealias was also called GroupieViewHolder for similar reasons, I think it's a good idea overall.
@DarrenAtherton49
Copy link

@DarrenAtherton49 DarrenAtherton49 commented Sep 17, 2019

Upvote for GroupieViewHolder. What is the reasoning behind the databinding and kotlin-android-extensions` renaming?
@ValCanBuild
Copy link
Collaborator Author

@ValCanBuild ValCanBuild commented Sep 17, 2019

@DarrenAtherton49 Its a more minor annoyance but the fact they all share a class name makes it less clear which one is used and can lead to errors/frustrations when importing. If you use the main library + either the databinding or kotlin extension one then you end up with 2 things named the same way.
ValCanBuild added a commit that referenced this issue Sep 23, 2019
@ValCanBuild
Issue #287 Rename ViewHolder to GroupieViewHolder
Loading status checks…
d369f69
@ValCanBuild
Copy link
Collaborator Author

@ValCanBuild ValCanBuild commented Sep 23, 2019

PR created #293
ValCanBuild added a commit that referenced this issue Sep 24, 2019
@ValCanBuild
Issue #287 Rename ViewHolder to GroupieViewHolder
Verified
This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: 4AEE18F83AFDEB23 Learn about vigilant mode.
Loading status checks…
027c0e9
@ValCanBuild
Copy link
Collaborator Author

@ValCanBuild ValCanBuild commented Sep 24, 2019

Now deployed in 2.6.0. Thank you for your feedback
@amitav13 amitav13 mentioned this issue Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
@ValCanBuild @DarrenAtherton49 @Zhuinden