New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in notify.d scripts #21

Closed
sbrandtb opened this Issue Apr 4, 2016 · 1 comment

Comments

2 participants
@sbrandtb

sbrandtb commented Apr 4, 2016

all of 200-write, 400-notify-send and 600-mail use bash built-in test syntax ([[ ... ]]), but are executed with /bin/sh which makes the overrides for not sending mail/notifies/writes useless. The error is mostly unnoticed because the shell just skips the test and carries on.

Example: https://github.com/liske/needrestart/blob/master/ex/notify.d/600-mail#L25

I'm not a shell hero, that's why I'm opening an issue and not a pull request. I can imagine either using /bin/bash or rewriting the test like if [ "$NR_NOTIFYD_DISABLE_MAIL" = '1' ]; then to fix the issue. I'm happy to create a pull request if someone points me to the "better" solution.

liske added a commit that referenced this issue Apr 9, 2016

[Bug] Fix bashisms in /etc/needrestart/notify.d/* (Debian Bug#818001 …
…by Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn@axis.com>; github issue #21 by Sebastian Brandt @sbrandtb).
@sbrandtb

This comment has been minimized.

sbrandtb commented Apr 11, 2016

Thanks for fixing!

@liske liske added the bug label Apr 13, 2016

@liske liske self-assigned this Apr 13, 2016

@liske liske closed this Apr 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment