Sort openPorts and failedPorts before returning#146
Merged
Conversation
β Deploy Preview for web-check ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
lissy93
approved these changes
May 28, 2024
aristech
pushed a commit
to aristech/web-check
that referenced
this pull request
Jan 7, 2026
Sort openPorts and failedPorts before returning
SmartMur
pushed a commit
to SmartMur/web-check
that referenced
this pull request
Apr 5, 2026
Sort openPorts and failedPorts before returning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses an issue where the order of ports in the scan results (openPorts and failedPorts) appeared random due to the asynchronous nature of the port checking process.
Problem:
The port scanning process involves checking multiple ports asynchronously. As a result, ports are added to the openPorts and failedPorts arrays in the order in which the checks complete, rather than in numerical order. This leads to an unpredictable and unsorted list of ports in the final results.
Solution:
To ensure consistency and readability, the arrays openPorts and failedPorts are now explicitly sorted in ascending numerical order before being returned. This sorting is done after all port checks are complete, ensuring that the final output is always in a predictable, ordered format.
Changes:
These changes improve the readability and usability of the scan results, making it easier for users to interpret the output.