From 87d65d2f821145ddd2464b6d19c8688a4825571b Mon Sep 17 00:00:00 2001 From: Westbrook Johnson Date: Wed, 19 Sep 2018 14:48:37 -0400 Subject: [PATCH 1/2] Add disconnectedCallback stub. --- src/lib/updating-element.ts | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/lib/updating-element.ts b/src/lib/updating-element.ts index a84cc54c..a79d5ebf 100644 --- a/src/lib/updating-element.ts +++ b/src/lib/updating-element.ts @@ -396,6 +396,13 @@ export abstract class UpdatingElement extends HTMLElement { } } + /** + * Allows for `super.disconnectedCallback()` in extensions while + * reserving the positibility of making non-breaking feature additions + * when disconnecting at some point in the future. + */ + disconnectedCallback() {} + /** * Synchronizes property values when attributes change. */ @@ -610,4 +617,4 @@ export abstract class UpdatingElement extends HTMLElement { * * @param _changedProperties Map of changed properties with old values */ protected firstUpdated(_changedProperties: PropertyValues) {} -} \ No newline at end of file +} From 5ccb6c45c0e0ba5960efaa4bab700416c472564c Mon Sep 17 00:00:00 2001 From: Westbrook Johnson Date: Tue, 25 Sep 2018 20:25:53 -0400 Subject: [PATCH 2/2] Correct spelling --- src/lib/updating-element.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/lib/updating-element.ts b/src/lib/updating-element.ts index a79d5ebf..2f642e64 100644 --- a/src/lib/updating-element.ts +++ b/src/lib/updating-element.ts @@ -398,7 +398,7 @@ export abstract class UpdatingElement extends HTMLElement { /** * Allows for `super.disconnectedCallback()` in extensions while - * reserving the positibility of making non-breaking feature additions + * reserving the possibility of making non-breaking feature additions * when disconnecting at some point in the future. */ disconnectedCallback() {}