Skip to content

Fix cssResult.toString type #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2019
Merged

Fix cssResult.toString type #546

merged 1 commit into from
Feb 21, 2019

Conversation

@balloob
Copy link
Contributor

@balloob balloob commented Feb 6, 2019

Typescript uses the lowercase string type, not the String class.

Per #508 (comment)

@balloob balloob mentioned this pull request Feb 6, 2019
Merged
@justinfagnani justinfagnani merged commit 36e1991 into lit:master Feb 21, 2019
@balloob balloob deleted the patch-1 branch February 21, 2019 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfagnani justinfagnani justinfagnani approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@balloob @justinfagnani @googlebot