Skip to content

Fix static property for closure #926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 16, 2020
Merged

Fix static property for closure #926

merged 1 commit into from
Mar 16, 2020

Conversation

@sorvell
Copy link
Member

@sorvell sorvell commented Mar 16, 2020

Static properties must use @nocollapse.

Fix static property for closure
b28ebb8 
Static properties must use `@nocollapse`.
@sorvell sorvell requested a review from kevinpschaaf March 16, 2020 17:12
@sorvell sorvell requested a review from justinfagnani as a code owner March 16, 2020 17:12
@kevinpschaaf kevinpschaaf merged commit 6a4c94f into master Mar 16, 2020
@kevinpschaaf kevinpschaaf deleted the closure-fixes branch March 16, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevinpschaaf kevinpschaaf kevinpschaaf approved these changes

@justinfagnani justinfagnani Awaiting requested review from justinfagnani justinfagnani is a code owner

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sorvell @kevinpschaaf @googlebot