You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be nice if the current exception being handled in on_exception function could pass the exception's instance to the on_giveup handler.
Also i've noticed that there's only an "empty" raise statement after giving up on retrying. Wouldn't it be correct to reraise the current exception's instance itself?
**When StopIteration is raised the exception being handled when calling the decorated function is reraised.
It would be nice if the current exception being handled in
on_exception
function could pass the exception's instance to theon_giveup
handler.Also i've noticed that there's only an "empty" raise statement after giving up on retrying. Wouldn't it be correct to reraise the current exception's instance itself?
**When
StopIteration
is raised the exception being handled when calling the decorated function is reraised.Snippet with the code i'm talking about:
backoff/backoff/_sync.py
Lines 100 to 108 in 229d30a
The text was updated successfully, but these errors were encountered: