Skip to content

Conversation

@cdecompilador
Copy link
Contributor

I remembered using something like this is in some language and tried to implement it, the comments i wrote are cargo doc ready,
sorry for the ton of commits im used to git on terminal but i tried with vscode integrated ui.
Hope its useful, create some issues in the future and i will fix them in order to contrib

@ChillFish8
Copy link
Contributor

I would probably move this into the class itself as a instance method rather than a single function to urge people to re-use the instance and not re-compile the pattern every time (the Regex lib's compile is really rather heavy and slow)

Would also like it if you would mind deleting the binary, cache and lock files that I think your VSC has sent with the pr. 😄

@cdecompilador
Copy link
Contributor Author

In the last pull request its fixed all the crap that vscode sent. Sounds like a good idea move it to the class but also would be great to have into the library powerfull public functions to allow easier scriping.

@ChillFish8
Copy link
Contributor

Seems reasonable, might worth having a seperate file for all the public functions vs all in one file but that can be done later when I get around to reorganising everything.

@ChillFish8 ChillFish8 merged commit 0680fc7 into litmus-web:main Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants