Response Body modification in HTTP Status code experiment #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n body and status; Removed unneccesary logging Signed-off-by: Akash Shrivastava <akash.shrivastava@harness.io>
avaakash
requested review from
ispeakc0de,
ksatchit and
uditgaurav
as code owners
Jonsy13
reviewed
Sep 8, 2022
Jonsy13
reviewed
Sep 8, 2022
Signed-off-by: Akash Shrivastava <akash.shrivastava@harness.io>
uditgaurav
approved these changes
Sep 15, 2022
uditgaurav
reviewed
Sep 15, 2022
| // sleep 10 is added for proxy-server to be ready for creating proxy and adding toxics | ||
| chaosCommand := fmt.Sprintf("%s && sleep 10 && %s && %s", startProxyServerCommand, createProxyCommand, createToxicCommand) | ||
| // sleep 2 is added for proxy-server to be ready for creating proxy and adding toxics | ||
| chaosCommand := fmt.Sprintf("%s && sleep 2 && %s && %s", startProxyServerCommand, createProxyCommand, createToxicCommand) |
There was a problem hiding this comment.
We should remove the sleep and provide some cmd that would check the proxy server is ready in the future.
SaptarshiSarkar12
pushed a commit
to SaptarshiSarkar12/litmus-go
that referenced
this pull request
Sep 21, 2022
…s#556) * added response body in status code; Added content encoding and type in body and status; Removed unnecessary logging Signed-off-by: Akash Shrivastava <akash.shrivastava@harness.io> Signed-off-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akash Shrivastava akash.shrivastava@harness.io
What this PR does / why we need it:
This PR adds the ability to modify the response body in the HTTP status code experiment.
It also adds support to provide the content type and encoding for the body in modify body and status code experiments.
Checklist:
breaking-changestagrequires-upgradetag