fix(abort): fixing chaosresult annotation conflict while updating chaosresult for abort scenarios #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
neelanjan00
approved these changes
Sep 20, 2022
ksatchit
approved these changes
Sep 20, 2022
SaptarshiSarkar12
pushed a commit
to SaptarshiSarkar12/litmus-go
that referenced
this pull request
Sep 21, 2022
…osresult for abort scenarios (litmuschaos#567) * fix(result): fix chaosresult update conflict issue Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> Signed-off-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
chinmaym07
pushed a commit
to chinmaym07/litmus-go
that referenced
this pull request
Sep 24, 2022
…osresult for abort scenarios (litmuschaos#567) * fix(result): fix chaosresult update conflict issue Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
chinmaym07
pushed a commit
to chinmaym07/litmus-go
that referenced
this pull request
Sep 24, 2022
…osresult for abort scenarios (litmuschaos#567) * fix(result): fix chaosresult update conflict issue Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> Signed-off-by: chinmaym07 <b418020@iiit-bh.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
PR to fix
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Issue:
In abort scenarios - helper pod keep annotating the chaos-result for targets and their revert status. At the same time experiment pod is updating the chaosresult for abort in parallel
Experiment pod get and update the chaosresult but in the mean-time helper pod updates the chaosresult for annotations, which cause the update function to fail.
Checklist:
breaking-changestagrequires-upgradetag