fix(stress): kill the stress process for abort #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
neelanjan00
reviewed
Sep 23, 2022
uditgaurav
previously approved these changes
Sep 23, 2022
Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io>
chinmaym07
pushed a commit
to chinmaym07/litmus-go
that referenced
this pull request
Sep 24, 2022
* fix(stress): kill the stress process for abort Signed-off-by: Shubham Chaudhary <shubham.chaudhary@harness.io> Signed-off-by: chinmaym07 <b418020@iiit-bh.ac.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham Chaudhary shubham.chaudhary@harness.io
What this PR does / why we need it:
Issue
For long chaos duration, if we abort the experiment. It doesn't revert the chaos immediately. It waits for the chaos duration to over before reverting chaos
Cause
It kills the parent process as part of revert but stress-ng orphaned child keep running so stress process persist in target application
Workaround
Launch the nsutil process with groupId. All the child processed can be deleted using this groupId
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Checklist:
breaking-changestagrequires-upgradetag