-
Notifications
You must be signed in to change notification settings - Fork 688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alter email to base64, because the regex enconding #3705
Conversation
Signed-off-by: Deivid <deivid.dgm@gmail.com>
39c8f15
to
e8885b2
Compare
Signed-off-by: Deivid <deivid.dgm@gmail.com> Signed-off-by: Deivid <deivid.dgm@gmail.com>
583fae3
to
6153aee
Compare
|
Thanks, @deividMatos for this PR. One quest- Have you tested it in your local dev? |
Yes, I tested it with a member of my squad and we created several flows to test in different scenarios, all in local dev |
|
Thanks @deividMatos for this PR! This will unblock a lot of users! Have test the changes and will take it as part of our next release! 🚀 |
|
Thanks @deividMatos works for us too ! |
|
Hi, Could we decode this in the UI to display the originating user email ? |
|
Hi @ludovic-pourrat , this is already handled in the UI. Attaching a screenshot for reference! |
|
@amityt my bad my graphql-server was not updated, after applying the patch on my deployment, many thanks for your answer ! |

Proposed changes
Changed the user email to base64 for the k8s labels objects, regarding to this issue. #3634
This was implemented based on this comment for PR #3648.
Types of changes
What types of changes does your code introduce to Litmus? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Dependency
Special notes for your reviewer: