Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding SingleBranch: true in the git clone options #3792

Merged
merged 4 commits into from
Oct 19, 2022
Merged

Adding SingleBranch: true in the git clone options #3792

merged 4 commits into from
Oct 19, 2022

Conversation

imrajdas
Copy link
Member

Reverts #3776

@codesniffy codesniffy bot added the size/XS label Oct 17, 2022
gdsoumya
gdsoumya requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@gdsoumya gdsoumya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should only clone a single branch to reduce unnecessary data being downloaded.
This clone option should force only the required branch data to be cloned :

SingleBranch:  true,

@imrajdas
Copy link
Member Author

imrajdas commented Oct 17, 2022 •
edited
Loading

We should only clone a single branch to reduce unnecessary data being downloaded. This clone option should force only the required branch data to be cloned :

SingleBranch:  true,

@amityt - Will it work with the git pull in go-git?

@gdsoumya
Copy link
Member

We should only clone a single branch to reduce unnecessary data being downloaded. This clone option should force only the required branch data to be cloned :

SingleBranch:  true,

@amityt - Will it work with the git pull in go-git?

It already works and is tested. I did the same with gitops feature ref:

litmus/litmus-portal/graphql-server/pkg/gitops/gitops.go

Line 178 in 45693e9

SingleBranch: true,

@codesniffy codesniffy bot added size/S and removed size/XS labels Oct 17, 2022
@imrajdas imrajdas changed the title Revert "Adding depth=1 in the git clone options" Adding SingleBranch: true in the git clone options Oct 17, 2022
@gdsoumya
Copy link
Member

@imrajdas LGTM, but lint check and dco is failing, please fix before merging

@imrajdas imrajdas merged commit 88719e9 into master Oct 19, 2022
@imrajdas imrajdas deleted the revert-3776-add-depth branch October 19, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jonsy13 Jonsy13 Jonsy13 approved these changes

@gdsoumya gdsoumya gdsoumya approved these changes

@amityt amityt Awaiting requested review from amityt

Assignees
No one assigned
Labels
PR: Changes Requested READY TO MERGE size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@imrajdas @gdsoumya @Jonsy13