Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/Chaoscenter: Added test cases for Grpc Handler #4189

Merged
merged 13 commits into from Nov 8, 2023

Conversation

Freedisch
Copy link
Contributor

@Freedisch Freedisch commented Sep 27, 2023

Proposed changes:

This PR add test cases for Chaoscenter authentication handler pkg

Types of changes

What types of changes does your code introduce to Litmus? Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bugfix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices applies)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the commit for DCO to be passed.
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

Dependency

  • Please add the links to the dependent PR need to be merged before this (if any).

Special notes for your reviewer:

Signed-off-by: Freedisch <freeproduc@gmail.com>
Signed-off-by: Freedisch <freeproduc@gmail.com>
Signed-off-by: Freedisch <freeproduc@gmail.com>
Signed-off-by: Freedisch <freeproduc@gmail.com>
@Freedisch Freedisch marked this pull request as draft September 27, 2023 08:58
Signed-off-by: Freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
@Freedisch Freedisch marked this pull request as ready for review October 11, 2023 01:35
Signed-off-by: freedisch <freeproduc@gmail.com>
@Freedisch
Copy link
Contributor Author

https://app.codecov.io/gh/Freedisch/litmus/tree/cov to track the current code cov

@Saranya-jena Saranya-jena requested review from Jonsy13 and SarthakJain26 and removed request for Jonsy13 October 11, 2023 05:06
@namkyu1999 namkyu1999 added the LFX-MENTORSHIP Linux Foundation Mentor ship Issue label Oct 11, 2023
@Freedisch Freedisch changed the title Tests/Chaoscenter: Added test cases for Handler pkg Tests/Chaoscenter: Added test cases for Grpc Handler Oct 11, 2023
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Signed-off-by: freedisch <freeproduc@gmail.com>
Copy link
Member

@namkyu1999 namkyu1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀, Can you also add negative cases?

@Freedisch
Copy link
Contributor Author

LGTM 🚀, Can you also add negative cases?

Sure, I'm on it

Signed-off-by: freedisch <freeproduc@gmail.com>
Copy link
Contributor

@Saranya-jena Saranya-jena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Saranya-jena Saranya-jena merged commit 7f2d8cd into litmuschaos:master Nov 8, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LFX-MENTORSHIP Linux Foundation Mentor ship Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants