fix(snapshot): make fake display size big enough to avoid align issue. #2883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neo Xu <neo.xu1990@gmail.com> Change-Id: I5a5e39f15b816bc281a6b9fb348a2adebb947368
|
It still doesn't solve the issue if the object is clipped on the left or top, but surely fixes some common use cases. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snapshot may be different than content on display
As discussed in #2593 , we cannot avoid this issue, but can improve most cases to make snapshot as close to real content on display.
Below is the result of making this change using lv_example_snapshot_1()
Checkpoints
code-format.pyfrom thescriptsfolder. astyle needs to be installed.