Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken CI #69

Merged
merged 2 commits into from Jun 6, 2019

Conversation

Projects
None yet
3 participants
@y-yagi
Copy link
Contributor

commented Jun 6, 2019

Hi!

Currently, some Rubocop checks fails. This PR fixes those checks.
https://travis-ci.org/liufengyun/hashdiff/jobs/540181300

Thanks.

@y-yagi y-yagi changed the title Fix broken ci Fix broken CI Jun 6, 2019

y-yagi added some commits Jun 6, 2019

Disable `Style/NumericPredicate`
This gem still supports old Ruby's that can't use numeric predicate
methods.
Disable `Style/RedundantFreeze`
Since removing `freeze` cause to hit another cop, so disable it.
Ref: https://travis-ci.org/liufengyun/hashdiff/jobs/542175837#L532

@y-yagi y-yagi force-pushed the y-yagi:fix_broken_ci branch from 268603f to d0f4546 Jun 6, 2019

@liufengyun

This comment has been minimized.

Copy link
Owner

commented Jun 6, 2019

Thanks a lot @y-yagi 🎉

@liufengyun liufengyun merged commit e27625e into liufengyun:master Jun 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@y-yagi y-yagi deleted the y-yagi:fix_broken_ci branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.