{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":301552097,"defaultBranch":"master","name":"cilium","ownerLogin":"liuyuan10","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2020-10-05T22:12:18.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4546386?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1703030351.0","currentOid":""},"activityList":{"items":[{"before":"f10449eacd4b91b5c095afc94962cb6a15a7acfe","after":"27aa5a9e100dbd84395d60e8ae52d448fd156617","ref":"refs/heads/fix-nat","pushedAt":"2023-12-20T00:00:01.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"},"commit":{"message":"Don't GC CT and NAT entries for host-network\n\nhost node IPs are not added into filter.ValidIPs unless\nEnableHostFirewall. This doesn't make sense because SNAT still happens for\nhost network traffic to avoid port conflict with existing NAT\nsessions.\n\nThis change adds all node IPs into filter.ValidIPs without\nEnableHostFirewall to make sure the CT\nand NAT entries are not cleared by GC.\n\nSigned-off-by: Yuan Liu <liuyuan@google.com>","shortMessageHtmlLink":"Don't GC CT and NAT entries for host-network"}},{"before":null,"after":"f10449eacd4b91b5c095afc94962cb6a15a7acfe","ref":"refs/heads/fix-nat","pushedAt":"2023-12-19T23:59:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"},"commit":{"message":"Don't GC CT and NAT entries for host-network\n\nhost node IPs are not added into filter.ValidIPs unless\nEnableHostFirewall. This doesn't make sense because SNAT still happens for\nhost network traffic to avoid port conflict with existing NAT\nsessions.\n\nThis change adds all node IPs into filter.ValidIPs without\nEnableHostFirewall to make sure the CT\nand NAT entries are not cleared by GC.","shortMessageHtmlLink":"Don't GC CT and NAT entries for host-network"}},{"before":"5569404ad56fccc161059544b85692f900fab8c8","after":"83f9911d33a3beb72690709e15d881b586bea4c6","ref":"refs/heads/upstream_fixneigh","pushedAt":"2023-10-31T09:53:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aanm","name":"André Martins","path":"/aanm","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/5714066?s=80&v=4"},"commit":{"message":"don't remove neighbor link state file if migrateOnly\n\nNodeCleanNeighbors is also called when enable-l2-neigh-discovery with\nmigrateOnly==false. In that case, all existing arp entries can still be\nremoved because neighLastPingByNextHop is still empty\n(https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2013).\nThe neighbor link state file then is removed https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2113\n\nThe file is only resotred again when next time\nNodeConfigurationChanged() is called.\n\nThis can break arp entry cleanup when next time cilium is started\nwithout enable-l2-neigh-discovery\n\nSigned-off-by: Yuan Liu <liuyuan@google.com>","shortMessageHtmlLink":"don't remove neighbor link state file if migrateOnly"}},{"before":"c34280690d894c12f3f14059b273066f54bb4977","after":"5569404ad56fccc161059544b85692f900fab8c8","ref":"refs/heads/upstream_fixneigh","pushedAt":"2023-10-17T21:25:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"},"commit":{"message":"don't remove neighbor link state file if migrateOnly\n\nNodeCleanNeighbors is also called when enable-l2-neigh-discovery with\nmigrateOnly==false. In that case, all existing arp entries can still be\nremoved because neighLastPingByNextHop is still empty\n(https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2013).\nThe neighbor link state file then is removed https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2113\n\nThe file is only resotred again when next time\nNodeConfigurationChanged() is called.\n\nThis can break arp entry cleanup when next time cilium is started\nwithout enable-l2-neigh-discovery\n\nSigned-off-by: Yuan Liu <liuyuan@google.com>","shortMessageHtmlLink":"don't remove neighbor link state file if migrateOnly"}},{"before":"fcdb2c62b4c89a342adf3c82ef6aeb7ebdcc3e34","after":"c34280690d894c12f3f14059b273066f54bb4977","ref":"refs/heads/upstream_fixneigh","pushedAt":"2023-10-17T21:05:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"},"commit":{"message":"don't remove neighbor link state file if migrateOnly\n\nNodeCleanNeighbors is also called when enable-l2-neigh-discovery with\nmigrateOnly==false. In that case, all existing arp entries can still be\nremoved because neighLastPingByNextHop is still empty\n(https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2013).\nThe neighbor link state file then is removed https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2113\n\nThe file is only resotred again when next time\nNodeConfigurationChanged() is called.\n\nThis can break arp entry cleanup when next time cilium is started\nwithout enable-l2-neigh-discovery","shortMessageHtmlLink":"don't remove neighbor link state file if migrateOnly"}},{"before":null,"after":"fcdb2c62b4c89a342adf3c82ef6aeb7ebdcc3e34","ref":"refs/heads/upstream_fixneigh","pushedAt":"2023-10-17T21:04:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"},"commit":{"message":"don't remove neighbor link state file if migrateOnly\n\nNodeCleanNeighbors is also called when enable-l2-neigh-discovery with\nmigrateOnly==false. In that case, all existing arp entries can still be\nremoved because neighLastPingByNextHop is still empty\n(https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2013).\nThe neighbor link state file then is removed https://github.com/cilium/cilium/blob/main/pkg/datapath/linux/node.go#L2113\n\nThe file is only resotred again when next time\nNodeConfigurationChanged() is called.\n\nThis can break arp entry cleanup when next time cilium is started\nwithout enable-l2-neigh-discovery\n\nChange-Id: Iabf92206a51a5063e2abd962b5205ec49334c1bc","shortMessageHtmlLink":"don't remove neighbor link state file if migrateOnly"}},{"before":"18627d86daaffbfb3042a4e6449f142a10e948f7","after":null,"ref":"refs/heads/icmp-nat-upstream","pushedAt":"2023-04-28T16:55:47.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"}},{"before":"99ce1df5977bb44fb4100923e22155a714cd109c","after":"18627d86daaffbfb3042a4e6449f142a10e948f7","ref":"refs/heads/icmp-nat-upstream","pushedAt":"2023-04-27T16:49:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"},"commit":{"message":"bpf/nat: implement support of ICMP4 fragmentation needed at egress\n\nPR #18414 added support for ingress ICMP \"need to frag\" support to hande\nthose sent by remote routers. This commit mirrors it to support such\nICMP sent from endpoints.\n\nThe use case is that pod is redirecting traffic from the world into a\ntunnel, which has smaller MTU. It may return a ICMP \"frag needed\" to the\nremote server that requires SNAT to happen properly on both outer and\ninner headers.\n\nSigned-off-by: Yuan Liu <liuyuan@google.com>","shortMessageHtmlLink":"bpf/nat: implement support of ICMP4 fragmentation needed at egress"}},{"before":"758e3b151e64da876eb9164256d1cd41d7555ab8","after":"99ce1df5977bb44fb4100923e22155a714cd109c","ref":"refs/heads/icmp-nat-upstream","pushedAt":"2023-04-25T17:41:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"}},{"before":"0937f335cca95fa66a03d1ddc2ae60d0eec30002","after":"758e3b151e64da876eb9164256d1cd41d7555ab8","ref":"refs/heads/icmp-nat-upstream","pushedAt":"2023-04-25T17:27:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"}},{"before":"f954e1f5c2205c8a4b352270df8373c1498c083b","after":"0937f335cca95fa66a03d1ddc2ae60d0eec30002","ref":"refs/heads/icmp-nat-upstream","pushedAt":"2023-04-21T23:53:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"}},{"before":"41cc9e10abd64b3587cff1c05554615ac771d055","after":"f954e1f5c2205c8a4b352270df8373c1498c083b","ref":"refs/heads/icmp-nat-upstream","pushedAt":"2023-04-21T23:00:24.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"}},{"before":"77df5cc734936fe6cf4d39134f506a38207a9bc0","after":"41cc9e10abd64b3587cff1c05554615ac771d055","ref":"refs/heads/icmp-nat-upstream","pushedAt":"2023-04-21T22:59:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"}},{"before":"554b8c509166cdc94e61a1a41015f93f80f63a2b","after":"77df5cc734936fe6cf4d39134f506a38207a9bc0","ref":"refs/heads/icmp-nat-upstream","pushedAt":"2023-04-21T22:04:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"}},{"before":"0f57b8ce20291afeac9702cc41c111a63e30d0d7","after":"554b8c509166cdc94e61a1a41015f93f80f63a2b","ref":"refs/heads/icmp-nat-upstream","pushedAt":"2023-04-21T22:00:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"}},{"before":null,"after":"0f57b8ce20291afeac9702cc41c111a63e30d0d7","ref":"refs/heads/icmp-nat-upstream","pushedAt":"2023-04-21T21:57:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"liuyuan10","name":"Yuan Liu","path":"/liuyuan10","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4546386?s=80&v=4"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADzkK5-AA","startCursor":null,"endCursor":null}},"title":"Activity · liuyuan10/cilium"}