Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.6.5 #1261

Merged
merged 25 commits into from Jun 4, 2019

Conversation

Projects
None yet
1 participant
@eos87
Copy link
Contributor

commented May 13, 2019

No description provided.

eos87 added some commits Apr 24, 2019

LBSD-2326 Add WhatsApp, Telegram and Viber to the SHARE button
Removed G+ sharing option from AMP and Default theme
Fixed some warning on AMP theme and also improved comment form
LBSD-2379 Completed migration of flux module to TS and turned it into…
… proper es6 class

Added types for this module, first ones in Liveblog
LBSD-2393 Adding ability to listen to editor changes in debounced mode
Then we hit the backend to update the flag of post so this way we have a real sense of activity in the editor.
This will make a better TTL for the flag, as it will count the expiration the last time user modified something in the editor
LBSD-2393 Implements new modal dialog for posts being edit which edit…
… flag expire

With this new approach we are trying to solve the problem of auto-closing the editor when the edit flag TTL reached
so instead we now have our own modal building components and a custom modal dialog that allows the user
picking from three options instead of closing the editor.

Additionally, the components were build using React and Typescript which makes them the first ones in our stack :)
the components are mostly react and they have a small combination with angular logic.

@eos87 eos87 force-pushed the devel branch from 844ca19 to 834070a May 27, 2019

Fix broken tests on travis
I have tried so many things on this topic. I'm listing some of them:
- Putting the webdriver-update and protractor commands directly in travis.yml file - no difference as using the npm run alternative makes them run correctly after all
- Update chrome driver to match current version of Chrome (v74 at the moment)
- Fixed CELERY_BEAT settings as this was adding lot of noise in the logs
- Found and fixed broken test connected with new modal window introduced in this release - we need to invest some time to improve some logic in the tests, like avoid using too open selectors

@eos87 eos87 force-pushed the devel branch from 98be3fd to b3ea8de May 28, 2019

@eos87 eos87 force-pushed the devel branch 2 times, most recently from 1b638fb to e769ff5 May 28, 2019

@eos87 eos87 force-pushed the devel branch from e769ff5 to b746b23 Jun 4, 2019

@eos87 eos87 merged commit 2c7ae7f into master Jun 4, 2019

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
fire:build duration: 5m48s
Details
fire:restart click "Details" to restart the build
Details
fire:www click "Details" to see the test instance
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.