Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple input types #321

Closed
9 tasks done
josevalim opened this issue Jun 4, 2021 · 10 comments
Closed
9 tasks done

Support multiple input types #321

josevalim opened this issue Jun 4, 2021 · 10 comments
Labels
feature New feature or request

Comments

@josevalim
Copy link
Contributor

josevalim commented Jun 4, 2021

We want to support:

Which other inputs do you need? Can you please describe your use case?

@josevalim josevalim added the feature New feature or request label Jun 4, 2021
@seanmor5
Copy link

Any plans for select and sliders? Here's an example notebook controlling some inference options using both: https://colab.research.google.com/github/tensorflow/lucid/blob/master/notebooks/differentiable-parameterizations/appendix/infinite_patterns.ipynb

@josevalim
Copy link
Contributor Author

@seanmor5 added to the list

@mcintyre94
Copy link
Contributor

Colour selection would be cool for customising VegaLite graphs, and the HTML input type is well supported so probably no need to do anything custom on the frontend side: https://caniuse.com/input-color

DateTime comes to mind too, though I don't have an immediate use case for that

@josevalim
Copy link
Contributor Author

Added color to the list. A PR is also welcome!

@jeantux
Copy link
Contributor

jeantux commented Jun 30, 2021

to the slider the return must be integer and checkbox/toogle must be boolean?
for both use IO.gets?

@josevalim
Copy link
Contributor Author

We use IO.gets for both and they always return strings. For sliders, it should be the integer as a string, not different from number. For checkbox, let’s go with true/false for now.

@mcintyre94
Copy link
Contributor

Any thoughts on using file inputs just to store the path to a selected file without itself doing any reading/streaming? Then the Elixir code could access that file using normal File functions however it makes sense to in the live book. I think that’d export sensibly too - if you have the same file on disk then it’ll just work, if you don’t then you can update the path variable to wherever you have your input file.

@josevalim
Copy link
Contributor Author

@mcintyre94 that would work for local deployments on livebook but not server ones.

@mcintyre94
Copy link
Contributor

@josevalim Ah got you. Would the expected behaviour for a server deployment be that you can upload a local file then? I'm guessing this would be read-only too?

@josevalim
Copy link
Contributor Author

Yeah, like a regular file upload. It may make sense to optimize this case that you mentioned but I am not quite sure how to handle it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants