Add doctest decorations to monaco editor per result#1911
Add doctest decorations to monaco editor per result#1911jonatanklosko merged 7 commits intolivebook-dev:mainfrom
Conversation
Adds a red circle on the gutter of the editor for failed doctests. Adds a green circle on the gutter of the editor for passed doctests.
|
Uffizzi Preview |
| @@ -23,7 +23,9 @@ defmodule Livebook.Runtime.Evaluator.Doctests do | |||
| |> Enum.map(&run_test/1) | |||
There was a problem hiding this comment.
I wonder if we could stream the gutter results per test? Before we run the test, we add a gray dot, after we run it, we make it red or green?
There was a problem hiding this comment.
Oh so that way the tests update the indicator as they are ran on the server, super cool!
This is what it looks like :)
Screen.Recording.2023-05-22.at.00.51.25.mov
|
I love it. :) I dropped one suggestion. |
|
Implemented suggestion 😁 |
|
It looks so good! |
|
@Sleepful awesome! Some tiny comments from me :) |
ccee1a0 to
e53723b
Compare
|
@jonatanklosko code almost done cooking...maybe? 🍳 |
|
@Sleepful looks good, final nitpicks. Please run |
|
@Sleepful are you running |
|
@jonatanklosko aha yeah. I tried both commands. I am struggling slightly with this |
|
should work now :) |
|
Exciting!!! Thanks for the help @jonatanklosko |
Adds a red circle on the gutter of the editor for failed doctests.
Adds a green circle on the gutter of the editor for passed doctests.
Re-attempt of #1789
Following implementation details by @jonatanklosko #1789 (comment)