From 527ec87921f9883d0197366656843ebc8ee64146 Mon Sep 17 00:00:00 2001 From: livecodepanos Date: Mon, 7 May 2018 14:06:01 +0100 Subject: [PATCH 1/3] [Bug 18585] Ensure Dictionary traps cmd+A --- .../dictionary/behaviors/revdictionarybehavior.livecodescript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Toolset/palettes/dictionary/behaviors/revdictionarybehavior.livecodescript b/Toolset/palettes/dictionary/behaviors/revdictionarybehavior.livecodescript index da5f4b51ee..b9a95bbe3d 100644 --- a/Toolset/palettes/dictionary/behaviors/revdictionarybehavior.livecodescript +++ b/Toolset/palettes/dictionary/behaviors/revdictionarybehavior.livecodescript @@ -93,7 +93,7 @@ end showUpgradeOptions # bug 17819 enable cmd+c in dictionary on commandKeyDown pWhich - if pWhich is not "C" then + if pWhich is not "C" and pWhich is not "A" then if pWhich is "W" then close me else From d9e32764aa8f22a157b87a5ca860db1b02f4f2c9 Mon Sep 17 00:00:00 2001 From: livecodepanos Date: Mon, 7 May 2018 14:07:26 +0100 Subject: [PATCH 2/3] [18585] Added bugfix note --- notes/bugfix-18585.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 notes/bugfix-18585.md diff --git a/notes/bugfix-18585.md b/notes/bugfix-18585.md new file mode 100644 index 0000000000..0b8f731b64 --- /dev/null +++ b/notes/bugfix-18585.md @@ -0,0 +1 @@ +# Ensure Dictionary does not pass cmd+A From fd5795718d1058bc390b7d52efca7812facca1e3 Mon Sep 17 00:00:00 2001 From: livecodepanos Date: Wed, 9 May 2018 16:43:41 +0100 Subject: [PATCH 3/3] Use a switch block in commandkeydown for more clarity --- .../revdictionarybehavior.livecodescript | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/Toolset/palettes/dictionary/behaviors/revdictionarybehavior.livecodescript b/Toolset/palettes/dictionary/behaviors/revdictionarybehavior.livecodescript index b9a95bbe3d..c690d515b4 100644 --- a/Toolset/palettes/dictionary/behaviors/revdictionarybehavior.livecodescript +++ b/Toolset/palettes/dictionary/behaviors/revdictionarybehavior.livecodescript @@ -93,11 +93,16 @@ end showUpgradeOptions # bug 17819 enable cmd+c in dictionary on commandKeyDown pWhich - if pWhich is not "C" and pWhich is not "A" then - if pWhich is "W" then + switch pWhich + case "A" + -- trap Cmd + A for select all + case "C" + -- trap Cmd + C for copy + break + case "W" close me - else + break + default pass commandKeyDown - end if - end if + end switch end commandKeyDown