From 86ee581b04b9401adc62ff8cfce8eaf726a286c6 Mon Sep 17 00:00:00 2001 From: BerndN Date: Mon, 4 Nov 2019 18:36:54 +0100 Subject: [PATCH 1/3] [Bug 22440] Fix card indentation in PB if stack name contains "of" PB checks for cards whether the owner of the card is a substack by testing for "stack" and "of" in owner name. This fails if the stack name contains "of" and returns wrong indentation level. --- .../project browser/revprojectbrowserbehavior.livecodescript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Toolset/palettes/project browser/revprojectbrowserbehavior.livecodescript b/Toolset/palettes/project browser/revprojectbrowserbehavior.livecodescript index 3f85105eee..70811a8bd5 100644 --- a/Toolset/palettes/project browser/revprojectbrowserbehavior.livecodescript +++ b/Toolset/palettes/project browser/revprojectbrowserbehavior.livecodescript @@ -1476,7 +1476,7 @@ function levelConnectors pObjectArray, pParentRow, pPosition put "branch" into tLevelConnectors[1] end if else if pObjectArray["type"] is "card" then - if word 1 of pObjectArray["owner"] is "stack" AND pObjectArray["owner"] contains "of" then + if word 1 of pObjectArray["owner"] is "stack" AND pObjectArray["owner"] contains "of stack " & quote then put sDisplayArray["objects"][pParentRow]["levels"] into tParentLevelConnectors if pPosition is "only" then if tParentLevelConnectors[1] is "branch" then put "vertical" into tLevelConnectors[1] From f5e971e0f05c40756cbbd901cf60cb17cf5bbc23 Mon Sep 17 00:00:00 2001 From: BerndN Date: Mon, 4 Nov 2019 18:38:22 +0100 Subject: [PATCH 2/3] Create bugfix-22440.md --- notes/bugfix-22440.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 notes/bugfix-22440.md diff --git a/notes/bugfix-22440.md b/notes/bugfix-22440.md new file mode 100644 index 0000000000..ef967cc0cb --- /dev/null +++ b/notes/bugfix-22440.md @@ -0,0 +1 @@ +# Fix card indentation in PB if stack name contains "of" From abc71cb9dc1fb0fefaa1e7915f38e2e308b87d8d Mon Sep 17 00:00:00 2001 From: BerndN Date: Tue, 5 Nov 2019 20:54:43 +0100 Subject: [PATCH 3/3] Update revprojectbrowserbehavior.livecodescript --- .../project browser/revprojectbrowserbehavior.livecodescript | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Toolset/palettes/project browser/revprojectbrowserbehavior.livecodescript b/Toolset/palettes/project browser/revprojectbrowserbehavior.livecodescript index 70811a8bd5..c3e3601413 100644 --- a/Toolset/palettes/project browser/revprojectbrowserbehavior.livecodescript +++ b/Toolset/palettes/project browser/revprojectbrowserbehavior.livecodescript @@ -1476,7 +1476,7 @@ function levelConnectors pObjectArray, pParentRow, pPosition put "branch" into tLevelConnectors[1] end if else if pObjectArray["type"] is "card" then - if word 1 of pObjectArray["owner"] is "stack" AND pObjectArray["owner"] contains "of stack " & quote then + if word 1 of pObjectArray["owner"] is "stack" AND the owner of pObjectArray["owner"] is not empty then put sDisplayArray["objects"][pParentRow]["levels"] into tParentLevelConnectors if pPosition is "only" then if tParentLevelConnectors[1] is "branch" then put "vertical" into tLevelConnectors[1]