This repository has been archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 20282 ]] Ensure 'the engine folder' returns a LiveCode path #5881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes an issue where 'the engine folder' would return a native looking path on Windows. The use of MCcmd has been replaced with a direct query of the executable module's filename.
|
@livecode-vulcan review ok 204d4f0 |
|
💙 review by @livecodeali ok 204d4f0 |
livecode-vulcan
added a commit
that referenced
this pull request
Aug 31, 2017
[[ Bug 20282 ]] Ensure 'the engine folder' returns a LiveCode path This patch fixes an issue where 'the engine folder' would return a native looking path on Windows. The use of MCcmd has been replaced with a direct query of the executable module's filename. Note: This fix is pertinent to 8 - a slightly different patch is needed for 9.
|
😞 test failure 204d4f0
|
|
@livecode-vulcan retry 204d4f0 |
livecode-vulcan
added a commit
that referenced
this pull request
Aug 31, 2017
[[ Bug 20282 ]] Ensure 'the engine folder' returns a LiveCode path This patch fixes an issue where 'the engine folder' would return a native looking path on Windows. The use of MCcmd has been replaced with a direct query of the executable module's filename. Note: This fix is pertinent to 8 - a slightly different patch is needed for 9.
livecode-vulcan
added a commit
that referenced
this pull request
Aug 31, 2017
[[ Bug 20282 ]] Ensure 'the engine folder' returns a LiveCode path (develop) This patch changes the implementation of fetching the engine folder to be consistent with how 9+ computes MCcmd. In particular, it uses the filename of the module containing the engine rather than the global executable module. Note: This is based on #5881 from develop-8.1 - that should be merged up before merging this PR.
|
😎 test success 204d4f0
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes an issue where 'the engine folder' would return a
native looking path on Windows. The use of MCcmd has been replaced
with a direct query of the executable module's filename.
Note: This fix is pertinent to 8 - a slightly different patch is needed for 9.