Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[[ Bug 20576 ]] Add Cancel button to OAuth2 dialog #6315

Merged
merged 2 commits into from Mar 6, 2018

Conversation

Projects
None yet
4 participants
@montegoulding
Copy link
Contributor

commented Feb 5, 2018

This patch adds a cancel button to the OAuth2 dialog allowing
users to cancel the dialog so that pages without a cancel button
or network issues are still able to be dismissed.

[[ Bug 20576 ]] Add Cancel button to OAuth2 dialog
This patch adds a cancel button to the OAuth2 dialog allowing
users to cancel the dialog so that pages without a cancel button
or network issues are still able to be dismissed.

@montegoulding montegoulding added the bug label Feb 5, 2018

@montegoulding montegoulding added this to the 9.0.0-rc-1 milestone Feb 5, 2018

@livecodeali

This comment has been minimized.

Copy link
Member

commented Mar 3, 2018

It's probably worth putting

         if the environment is "mobile" then
            set the defaultStack to the topStack
            if there is a widget tUniqueRef then
               delete widget tUniqueRef
            end if
            if there is a graphic tUniqueRef then
               delete graphic tUniqueRef
            end if
         else
            if there is a stack tUniqueRef then
               close stack tUniqueRef
            end if
         end if

into a separate function isn't it?

@montegoulding

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2018

Yes it probably is. Will do

@livecodeali

This comment has been minimized.

Copy link
Member

commented Mar 6, 2018

@livecode-vulcan

This comment has been minimized.

Copy link

commented Mar 6, 2018

💙 review by @livecodeali ok 6861f73

livecode-vulcan added a commit that referenced this pull request Mar 6, 2018

Auto-merge pull request #6315 from montegoulding/bugfix-20576
[[ Bug 20576 ]] Add Cancel button to OAuth2 dialog

This patch adds a cancel button to the OAuth2 dialog allowing
users to cancel the dialog so that pages without a cancel button
or network issues are still able to be dismissed.
@livecode-vulcan

This comment has been minimized.

Copy link

commented Mar 6, 2018

😎 test success 6861f73

  • try-community-armv6-android-api8: success
  • try-community-armv6-android-api9: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos11.2: success
  • try-community-universal-ios-iphonesimulator11.2: success
  • try-community-universal-mac-macosx10.6: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian7: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian7: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit 36cb11d into livecode:develop Mar 6, 2018

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/vulcan/cla Contributor Agreement signed by @montegoulding
continuous-integration/vulcan/pr The Vulcan build succeeded on 13 builders
continuous-integration/vulcan/review Approved by reviewer @livecodeali
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.