[[ Navigation Bar ]] Add option to highlight none of the icons #6404
Conversation
`set the hilitedItem of widget to 0` will disable the highlight The selected item index allowed minimum was changed to 0 If the hilitedItem is 0, then an empty string will be returned for the name.
This was generated as a demo for LCG, but if the team thinks it is worthwhile, I can add an enhancement request to Bugzilla and flesh out the docs a little bit more. |
@bwmilby I think this is definitely worthwhile! |
Roger. I’ll put something in BZ and update the PR. |
@@ -0,0 +1 @@ | |||
#LCG Demo - Add Navigation Bar option to highlight none of the icons |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bwmilby this note should be feature-nohighlight.md
or something like that and not mention the LCG demo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will submit another commit this evening. I will fix this and make sure all of the docs are updated.
Possibly a bug, but I have not been able to figure out how to properly reference another LCB library (com.livecode.library.iconsvg). It isn't invisible, but it doesn't link. I've only found one other reference to a LCB library (com.livecode.sort referenced from com.livecode.array - but both are modules), but it doesn't render either. |
Update documentation references for the new 0 option to have nothing highlighted. Add ability to set the selected icon name to "" to make nothing highlight. Updated documentation to indicate that custom icons are possible (reference Icon SVG Library). Renamed note and expanded to document potential backward compatibility issue (a call to `getNavSelectedItemName` in a previous version of the widget with nothing selected will throw an error).
@bwmilby can you explain your issue a bit more... are you saying you are having an issue with |
Issue is with documentation. For the icons, I think it would be good to point to the SVG Icon Library as a whole instead of listing all of the handlers. I tried 3 different ways, but none parse as a link. I have not looked at the source yet. Since it doesn’t impact the readability of the docs, I submitted this one the way I did. |
@@ -256,7 +258,7 @@ navigation bar, the remaining navigation items have their icons reset | |||
to the default icon. | |||
|
|||
References: hilitedItemIcons(property), itemLabels(property), | |||
itemNames(property) | |||
itemNames(property), com.livecode.library.iconsvg (library) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not parse as an actual link, but does appear in the list of references.
@livecode-vulcan review ok aa9649b |
💙 review by @montegoulding ok aa9649b |
[[ Navigation Bar ]] Add option to highlight none of the icons `set the hilitedItem of widget to 0` will disable the highlight The selected item index allowed minimum was changed to 0 If the hilitedItem is 0, then an empty string will be returned for the name.
😎 test success aa9649b
|
set the hilitedItem of widget to 0
will disable the highlightThe selected item index allowed minimum was changed to 0
If the hilitedItem is 0, then an empty string will be returned for the name.