Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[[ Navigation Bar ]] Add option to highlight none of the icons #6404

Merged
merged 2 commits into from Apr 6, 2020

Conversation

bwmilby
Copy link
Contributor

@bwmilby bwmilby commented Mar 11, 2018

set the hilitedItem of widget to 0 will disable the highlight
The selected item index allowed minimum was changed to 0
If the hilitedItem is 0, then an empty string will be returned for the name.

`set the hilitedItem of widget to 0` will disable the highlight
The selected item index allowed minimum was changed to 0
If the hilitedItem is 0, then an empty string will be returned for the name.
@bwmilby
Copy link
Contributor Author

bwmilby commented Mar 19, 2018

This was generated as a demo for LCG, but if the team thinks it is worthwhile, I can add an enhancement request to Bugzilla and flesh out the docs a little bit more.

@livecodeali
Copy link
Member

@bwmilby I think this is definitely worthwhile!

@bwmilby
Copy link
Contributor Author

bwmilby commented Apr 11, 2018

Roger. I’ll put something in BZ and update the PR.

@bwmilby bwmilby changed the title LCG Demo - Add Navigation Bar option to highlight none of the icons [[ Navigation Bar ]] Add option to highlight none of the icons Apr 12, 2018
@@ -0,0 +1 @@
#LCG Demo - Add Navigation Bar option to highlight none of the icons
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bwmilby this note should be feature-nohighlight.md or something like that and not mention the LCG demo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will submit another commit this evening. I will fix this and make sure all of the docs are updated.

@bwmilby
Copy link
Contributor Author

bwmilby commented Apr 20, 2018

Possibly a bug, but I have not been able to figure out how to properly reference another LCB library (com.livecode.library.iconsvg). It isn't invisible, but it doesn't link. I've only found one other reference to a LCB library (com.livecode.sort referenced from com.livecode.array - but both are modules), but it doesn't render either.

Update documentation references for the new 0 option to have nothing highlighted.
Add ability to set the selected icon name to "" to make nothing highlight.
Updated documentation to indicate that custom icons are possible (reference Icon SVG Library).
Renamed note and expanded to document potential backward compatibility issue (a call to `getNavSelectedItemName` in a previous version of the widget with nothing selected will throw an error).
@montegoulding
Copy link
Member

@bwmilby can you explain your issue a bit more... are you saying you are having an issue with use?

@bwmilby
Copy link
Contributor Author

bwmilby commented Apr 20, 2018

Issue is with documentation. For the icons, I think it would be good to point to the SVG Icon Library as a whole instead of listing all of the handlers. I tried 3 different ways, but none parse as a link. I have not looked at the source yet. Since it doesn’t impact the readability of the docs, I submitted this one the way I did.

@@ -256,7 +258,7 @@ navigation bar, the remaining navigation items have their icons reset
to the default icon.

References: hilitedItemIcons(property), itemLabels(property),
itemNames(property)
itemNames(property), com.livecode.library.iconsvg (library)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not parse as an actual link, but does appear in the list of references.

@montegoulding
Copy link
Member

@livecode-vulcan review ok aa9649b

@livecode-vulcan
Copy link
Contributor

💙 review by @montegoulding ok aa9649b

livecode-vulcan added a commit that referenced this pull request May 23, 2019
[[ Navigation Bar ]] Add option to highlight none of the icons

`set the hilitedItem of widget to 0` will disable the highlight
The selected item index allowed minimum was changed to 0
If the hilitedItem is 0, then an empty string will be returned for the name.
@livecode-vulcan
Copy link
Contributor

😎 test success aa9649b

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-sdk26_ndk16r15: success
  • try-community-arm64-android-sdk26_ndk16r15: success
  • try-community-x86-android-sdk26_ndk16r15: success
  • try-community-x86_64-android-sdk26_ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos12.1: success
  • try-community-universal-ios-iphonesimulator12.1: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodeali livecodeali merged commit 51a930b into livecode:develop Apr 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants