Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 21608 ]] Remove second break wait from invoke handler block #6744

Merged
merged 1 commit into from Oct 19, 2018
Merged

[[ Bug 21608 ]] Remove second break wait from invoke handler block #6744

merged 1 commit into from Oct 19, 2018

Conversation

montegoulding
Copy link
Member

This patch removes the call to MCBrowserRunloopBreakWait as we are
already using the LCB post command which does MCEngineRunloopBreakWait.

On iOS 12 this second break wait causes an app lockup that has been hard
to diagnose. Perhaps breaking an MCFiberDispatch pthread_cond_wait that
should not be broken.

@montegoulding montegoulding added this to the 9.0.2-rc-1 milestone Oct 19, 2018
@montegoulding
[[ Bug 21608 ]] Remove second break wait from invoke handler block
4f70c2f 
This patch removes the call to `MCBrowserRunloopBreakWait` as we are
already using the LCB `post` command which does `MCEngineRunloopBreakWait`.

On iOS 12 this second break wait causes an app lockup that has been hard
to diagnose. Perhaps breaking an `MCFiberDispatch` `pthread_cond_wait` that
should not be broken.
@runrevmark
Copy link
Contributor

We added the break wait to Post after the BreakWait was added to the browser widget, so removing it seems reasonable. However, we should probably file a bug about not being able to call BreakWait twice - once called, it shouldn't have any effect, which I thought was how it worked, so it suggests that there is another issue lurking somewhere with that.

@runrevmark
Copy link
Contributor

@livecode-vulcan review ok 4f70c2f

@livecode-vulcan
Copy link
Contributor

💙 review by @runrevmark ok 4f70c2f

livecode-vulcan added a commit that referenced this pull request Oct 19, 2018
@livecode-vulcan
Auto-merge pull request #6744 from montegoulding/bugfix-21608
986db02 
[[ Bug 21608 ]] Remove second break wait from invoke handler block

This patch removes the call to `MCBrowserRunloopBreakWait` as we are
already using the LCB `post` command which does `MCEngineRunloopBreakWait`.

On iOS 12 this second break wait causes an app lockup that has been hard
to diagnose. Perhaps breaking an `MCFiberDispatch` `pthread_cond_wait` that
should not be broken.
@livecode-vulcan
Copy link
Contributor

😎 test success 4f70c2f

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-sdk26_ndk16r15: success
  • try-community-arm64-android-sdk26_ndk16r15: success
  • try-community-x86-android-sdk26_ndk16r15: success
  • try-community-x86_64-android-sdk26_ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos12.0: success
  • try-community-universal-ios-iphonesimulator12.0: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit b0638bb into livecode:develop-9.0 Oct 19, 2018
@Brahmanathaswami
Copy link
Contributor

Brahmanathaswami commented Oct 22, 2018 •
edited

Can't we get this into 9.0.1 GM?
OR
How soon will 9.0.2 RC 1 released?

I had to (sad!) release a version of the app without the Lexicon... which I would like to rectify ASAP. Is there a way to patch this into my installation of LC?

Yeah, I know... it is not your fault. iOS 12 broke many things, even in its own settings!

@montegoulding
Copy link
Member Author

@Brahmanathaswami 9.0.2-rc-1 will be released as soon as we have resolved all blockers for it. There will also be some other issues resolved which are fairly critical in it.

@montegoulding montegoulding deleted the bugfix-21608 branch October 22, 2018 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
blocker bug vulcan/reviewed
Projects
None yet
Milestone
9.0.2-rc-1
5 participants
@montegoulding @runrevmark @livecode-vulcan @Brahmanathaswami @livecodepanos