Skip to content
This repository has been archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 12419 ]] Ensure Android ScrollViews don't cancel touch events #6942

Merged
merged 1 commit into from May 8, 2019

Conversation

montegoulding
Copy link
Member

This patch implements the onInterceptTouchEvent method in the vertical and
horizontal scroll views so that they do not cancel the touch events. Without
this patch the cancellation of the touch events causes a touch down to be unpaired
with an up or release event. Not that iOS Scrollers have a canCancelTouches
property but android scrollers do not.

This patch implements the `onInterceptTouchEvent` method in the vertical and
horizontal scroll views so that they do not cancel the touch events. Without
this patch the cancellation of the touch events causes a touch down to be unpaired
with an up or release event. Not that iOS Scrollers have a `canCancelTouches`
property but android scrollers do not.
@montegoulding montegoulding added this to the 9.0.5-rc-1 milestone Apr 3, 2019
@runrevmark
Copy link
Contributor

@montegoulding So I guess that this means the behavior of the Android scroller is now the same as the iOS scroller when the latter has 'canCancelTouches' false? Is this something we should mention in the docs?

@montegoulding
Copy link
Member Author

canCancelTouches is already an iOS only property which defaults to false so I'm not sure what else we need to say

@runrevmark
Copy link
Contributor

Okay - cool - if the iOS default is false - then there is no need to change any of the docs :)

@runrevmark
Copy link
Contributor

@livecode-vulcan review ok 63bc5f4

@livecode-vulcan
Copy link
Contributor

💙 review by @runrevmark ok 63bc5f4

livecode-vulcan added a commit that referenced this pull request May 8, 2019
[[ Bug 12419 ]] Ensure Android ScrollViews don't cancel touch events

This patch implements the `onInterceptTouchEvent` method in the vertical and
horizontal scroll views so that they do not cancel the touch events. Without
this patch the cancellation of the touch events causes a touch down to be unpaired
with an up or release event. Not that iOS Scrollers have a `canCancelTouches`
property but android scrollers do not.
@livecode-vulcan
Copy link
Contributor

😎 test success 63bc5f4

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-sdk26_ndk16r15: success
  • try-community-arm64-android-sdk26_ndk16r15: success
  • try-community-x86-android-sdk26_ndk16r15: success
  • try-community-x86_64-android-sdk26_ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos12.1: success
  • try-community-universal-ios-iphonesimulator12.1: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit 69ad4db into livecode:develop-9.0 May 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants