Skip to content

Conversation

@rektdeckard
Copy link
Contributor

@rektdeckard rektdeckard commented Sep 2, 2025

https://linear.app/livekit/issue/DPRO-506/add-production-safeguards-to-sandbox-template-repos

Uses shared deployment workflow to:

  • Make production deployments manually triggered as opposed to on push to main
  • Tag deployments with v# on merging to production branch

@vercel
Copy link

vercel bot commented Sep 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
sandbox-voice-assistant Ready Ready Preview Sep 9, 2025 3:04am

@rektdeckard rektdeckard requested review from Ocupe and lukasIO September 2, 2025 22:17
Copy link
Contributor

@Ocupe Ocupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.
One thought: If we want to reuse this logic for all the sandbox repos, we should consider making this workflow reusable. One possible solution is outlined here: https://docs.github.com/en/actions/reference/workflows-and-actions/reusable-workflows

Copy link
Contributor

@lukasIO lukasIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for reusable workflow across sandbox repos

@rektdeckard rektdeckard force-pushed the tobias/dpro-506-add-production-safeguards-to-sandbox-template-repos branch from 3499a6c to 2a9fc0e Compare September 9, 2025 03:03
@rektdeckard
Copy link
Contributor Author

Done 👍

@rektdeckard rektdeckard merged commit 72275b6 into main Sep 9, 2025
5 checks passed
@rektdeckard rektdeckard deleted the tobias/dpro-506-add-production-safeguards-to-sandbox-template-repos branch September 9, 2025 06:49
abdul-0-muheed pushed a commit to abdul-0-muheed/sdc-joint-frontend that referenced this pull request Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants