Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send network parameter with current network type #396

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Conversation

davidzhao
Copy link
Member

This is only supported on Chrome-like browsers at the moment.

This is only supported on Chrome-like browsers at the moment.
@davidzhao davidzhao requested a review from lukasIO August 16, 2022 00:04
@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2022

🦋 Changeset detected

Latest commit: 827aea0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukasIO
Copy link
Contributor

lukasIO commented Aug 16, 2022

by setting it via connect parameters we lose the ability to react to network changes.
Could imagine it would be useful to be able to have visibility of the changes while connected as well?

@davidzhao davidzhao merged commit 027ede3 into main Aug 17, 2022
@davidzhao davidzhao deleted the send-network-param branch August 17, 2022 16:20
@github-actions github-actions bot mentioned this pull request Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants