-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add websocketTimeout to RoomConnectOptions #834
Conversation
🦋 Changeset detectedLatest commit: 5bef732 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
src/api/SignalClient.ts
Outdated
reject(new ConnectionError('room connection has been cancelled (signal)')); | ||
}; | ||
|
||
console.log('timeout', opts.websocketTimeout); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console to remove
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
@@ -17,6 +17,7 @@ export class WebSocketCheck extends Checker { | |||
autoSubscribe: true, | |||
maxRetries: 0, | |||
e2eeEnabled: false, | |||
websocketTimeout: 15_000, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should it just use default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the reason for it being explicit here is that the default opts get applied on the room level, not on the client level. So the signal client API requires it to be present explicitly
No description provided.