Fix maxJoinAttempts in RTC Engine #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ebd8af3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
lukasIO
reviewed
Aug 16, 2023
| @@ -191,6 +191,7 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit | |||
| this.url = url; | |||
| this.token = token; | |||
| this.signalOpts = opts; | |||
| this.maxJoinAttempts = opts.maxRetries; | |||
There was a problem hiding this comment.
thanks for spotting this!
It seems like only adding this line would be sufficient though?
There was a problem hiding this comment.
Yeah. You are right.
Fixed
mpnri
force-pushed
the
fix-maxJoinAttempts-in-RTC-Engine
branch
from
8cf5f49
to
0855422
Compare
lukasIO
approved these changes
Aug 16, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
We have a
maxRetriesproperty inRoomConnectOptions, but it seems we never use it to retry the connection. On the other hand, we have amaxJoinAttemptsvalue in RTCEngine which is hard-coded and cannot be changed by room connect options.This PR allows to set the
maxJoinAttemptsvalue through themaxRetriesproperty inRoomConnectOptions.