Filter internal data streams out of livekit-ffi interface#1112
Merged
Conversation
Contributor
ChangesetThe following package versions will be affected by this PR:
|
xianshijing-lk
approved these changes
May 21, 2026
Contributor
xianshijing-lk
left a comment
xianshijing-lk
left a comment
There was a problem hiding this comment.
one nit. lgtm in general
… interface Without this, logs like the below will show up in the node sdk while rpc requests are occurring with rpc v2 capable participants: > ignoring incoming text stream due to no handler for topic: lk.rpc_request
…for internal topics
1egoman
force-pushed
the
filter-internal-data-streams
branch
from
99f4f90 to
04bf0dc
Compare
Merged
xianshijing-lk
pushed a commit
that referenced
this pull request
May 21, 2026
> [!IMPORTANT] > Merging this pull request will create these releases # livekit-datatrack 0.1.7 (2026-05-21) ## Features - Introduce pipeline options for remote data tracks, support multiple in-flight frames. ## Fixes - Fix compilation error in depacketizer test by using correct variable name. # livekit 0.7.42 (2026-05-21) ## Features - Introduce pipeline options for remote data tracks, support multiple in-flight frames. ## Fixes - Filter internal data streams out of livekit-ffi interface - #1112 (@1egoman) ### feat: add Android application context initialization for PlatformAudio support. Android requires `ContextUtils.initialize(applicationContext)` before WebRTC audio components can be created. This change: - Adds `livekit_ffi_initialize_android_context()` C FFI function for Unity and other FFI consumers - Uses `CreateAndroidAudioDeviceModule()` instead of generic `CreateAudioDeviceModule()` on Android - Handles empty device GUIDs on Android (falls back to index 0) - Documents Android-specific limitations: single default device, no app-level device selection Platform notes: - Android device enumeration returns only one "default" device with empty name/GUID - Audio routing (speaker/earpiece/Bluetooth) is controlled by Android's AudioManager, not WebRTC # webrtc-sys-build 0.3.18 (2026-05-21) ## Fixes - Disable default features for zip dependency # webrtc-sys 0.3.32 (2026-05-21) ## Fixes ### feat: add Android application context initialization for PlatformAudio support. Android requires `ContextUtils.initialize(applicationContext)` before WebRTC audio components can be created. This change: - Adds `livekit_ffi_initialize_android_context()` C FFI function for Unity and other FFI consumers - Uses `CreateAndroidAudioDeviceModule()` instead of generic `CreateAudioDeviceModule()` on Android - Handles empty device GUIDs on Android (falls back to index 0) - Documents Android-specific limitations: single default device, no app-level device selection Platform notes: - Android device enumeration returns only one "default" device with empty name/GUID - Audio routing (speaker/earpiece/Bluetooth) is controlled by Android's AudioManager, not WebRTC # libwebrtc 0.3.34 (2026-05-21) ## Fixes ### feat: add Android application context initialization for PlatformAudio support. Android requires `ContextUtils.initialize(applicationContext)` before WebRTC audio components can be created. This change: - Adds `livekit_ffi_initialize_android_context()` C FFI function for Unity and other FFI consumers - Uses `CreateAndroidAudioDeviceModule()` instead of generic `CreateAudioDeviceModule()` on Android - Handles empty device GUIDs on Android (falls back to index 0) - Documents Android-specific limitations: single default device, no app-level device selection Platform notes: - Android device enumeration returns only one "default" device with empty name/GUID - Audio routing (speaker/earpiece/Bluetooth) is controlled by Android's AudioManager, not WebRTC # livekit-ffi 0.12.60 (2026-05-21) ## Features - Introduce pipeline options for remote data tracks, support multiple in-flight frames. ### feat: add Android application context initialization for PlatformAudio support. Android requires `ContextUtils.initialize(applicationContext)` before WebRTC audio components can be created. This change: - Adds `livekit_ffi_initialize_android_context()` C FFI function for Unity and other FFI consumers - Uses `CreateAndroidAudioDeviceModule()` instead of generic `CreateAudioDeviceModule()` on Android - Handles empty device GUIDs on Android (falls back to index 0) - Documents Android-specific limitations: single default device, no app-level device selection Platform notes: - Android device enumeration returns only one "default" device with empty name/GUID - Audio routing (speaker/earpiece/Bluetooth) is controlled by Android's AudioManager, not WebRTC ## Fixes - Filter internal data streams out of livekit-ffi interface - #1112 (@1egoman) Co-authored-by: knope-bot[bot] <152252888+knope-bot[bot]@users.noreply.github.com>
1egoman
added a commit
to livekit/node-sdks
that referenced
this pull request
May 22, 2026
Includes fix to livekit/rust-sdks#1112
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, logs like the below would show up in the node sdk while rpc requests are occurring with rpc v2 capable participants:
So, adds a new mechanism to specify "internal topics" which should not be exposed into the room's public api interface. Also adds a new e2e test to exercise this case and ensure that these events aren't inadvertently exposed (which if they aren't exposed in
livekit, they won't be exposed inlivekit-ffi, which means they won't be exposed in end sdks).