Skip to content

fix(sip): send 487 Request Terminated after OK (CANCEL) for pending INVITE #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dennwc merged 1 commit into from
Jun 10, 2025
Merged

fix(sip): send 487 Request Terminated after OK (CANCEL) for pending INVITE #372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pkg/sip/inbound.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,9 +1161,7 @@
case r := <-cancels:
close(c.cancelled)
_ = tx.Respond(sip.NewResponseFromRequest(r, sip.StatusOK, "OK", nil))
c.mu.Lock()
c.drop()
c.mu.Unlock()
c.RespondAndDrop(sip.StatusRequestTerminated, "Request Terminated")

Check warning on line 1164 in pkg/sip/inbound.go

View check run for this annotation

Codecov / codecov/patch

pkg/sip/inbound.go#L1164 

Added line #L1164 was not covered by tests
return
case <-ticker.C:
}
Expand Down