Fix outbound destination setting to honor Route headers #489
Conversation
| req.RemoveHeader("Call-ID") | ||
| req.AppendHeader(&callID) | ||
|
|
||
| req.SetDestination(dest) |
There was a problem hiding this comment.
Removed, it now defaults to req.Destination(), which already respects Route headers.
This looks like it was introduced in the first iteration of outbound calling altogether.
The one possible downside I see to this is we will potentially re-resolve if DNS cache expires exactly in-between attempt 1 and any following re-transmit/re-auth attempt, causing an extra bit of latency.
However. I think this is still the right thing to do here.
There was a problem hiding this comment.
Update: Denys recalled the possible reason for this was to avoid DNS re-resolution mid call, possibly arriving to a different host without the previous INVITE credentials.
That is absolutely a valid concern,m but not for this change - req.SetDestination() simply stores a string, so we're subject to DNS re-resolution today, with SetDestination or without.
alexlivekit
changed the title
No description provided.