Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add projectId to stream and asset #68

Merged
merged 4 commits into from
May 27, 2024
Merged

Add projectId to stream and asset #68

merged 4 commits into from
May 27, 2024

Conversation

leszko
Copy link
Collaborator

@leszko leszko commented May 23, 2024

No description provided.

@leszko leszko requested a review from a team as a code owner May 23, 2024 11:00
@leszko leszko requested a review from gioelecerati May 23, 2024 11:00
victorges
victorges approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM anyway but I'd love to keep isMobile as localized as possible only in the API.

api.go Outdated Show resolved Hide resolved
gioelecerati
gioelecerati approved these changes May 27, 2024
View reviewed changes
api.go Outdated Show resolved Hide resolved
@leszko leszko merged commit 5d255cb into main May 27, 2024
2 checks passed
@leszko leszko deleted the rafal/add-project-id branch May 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges approved these changes

@gioelecerati gioelecerati gioelecerati approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leszko @victorges @gioelecerati