Prometheus metrics for recording feature #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yondonfu
requested changes
Dec 18, 2020
- recording_save_errors: number of errors during save to the recording OS - recording_saved_segments: number of segments saved to the recording OS - recording_save_latency: time takes to save segment to OS - also marked "segment_transcoded_appeared_total" and "segment_source_appeared_total" metrics with with "segment type" tag which can be "regular" (streams with recoding disabled) and "rec" (streams with recording enabled) Fixes #1709
darkdarkdragon
force-pushed
the
it/recording-metrics
branch
from
17583a1
to
53f8535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Prometheus metrics for recording feature
can be "regular" (streams with recoding disabled) and "rec" (streams with recording enabled)
Specific updates (required)
added new metics
How did you test each of these updates (required)
Manual
Does this pull request close any open issues?
Fixes #1709
Checklist:
./test.shpass