Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Client code for ServiceRegistry with ability to set service URI in CLI #456
Adds support for storing a service URI as a transcoder/orchestrator in the ServiceRegistry contract.
Dependent on the smart contract changes here: livepeer/protocol#223
Branched off of the current WIP V2 Networking branch because these changes only make sense in the context of the V2 networking architecture.
Added a few more commits around the ServiceURI. I'd like to get consensus on these changes since it's something that affects how users deal with command line arguments (ergo, a breaking change if anyone has scripts to automate node setup). Happy to spin this off into a separate PR if that works better.
Two things prompted these changes:
6d637af : Usability improvement in auto-discovering the public IP and informing the user that their node needs to be rebooted in order to pick up changes to ServiceURI. Note that the
4835711 : Checks the ServiceURI matches the public IP on startup. Ideally we'd kill the node if it doesn't match (since the transcoder would then be inaccessible), but we need to give active transcoders time to migrate, so we only print a warning for now.
Also offers a
We really need to communicate to our transcoders (through release notes, Discord, forums, readme, readthedocs, wiki) about the new public address requirement and the need to set the Service URI. I'll write up something so folks aren't caught by surprise once the release hits, but this set of commits needs to be signed off first.