Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
OS, heavily WIP #562
I'm still reading through this, but wanted to leave what I had so far.
The major bit of feedback is that I think we need a clearer separation between the manifest handling and the OS itself. Right now they are mixed up somewhat, and it's making things harder to follow. I'll think about it and review some more before making additional suggestions.
There is a significant issue with full playlists, they are not persistent across restarts, so I wonder if we should hold off on that feature for now and revisit once things are more settled. That might also give us an opportunity to integrate the feature better.
I also just noticed that there's a leak on the orchestrator side where manifests are never released after the transcode loop expires, but it's an old issue. However, this could compound if we're keeping full manifests in memory forever.