New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Feat #183 adaptive bitrate controller #191

Merged
merged 16 commits into from Sep 3, 2018

Conversation

Projects
None yet
2 participants
@ya7ya
Collaborator

ya7ya commented Aug 22, 2018

What does this pull request do? Explain your changes. (required)
this integrates with HLS.js to add the resolution control function to the chroma UI

Specific updates (required)

  • extending source to give access to hls.levels
  • simple css/html menu of available resolutions
  • ability to choose auto to pick resolution based on HLS ABR

How did you test each of these updates (required)

Code was tested against the m3u8 in issue #183
no automated testing included

Does this pull request close any open issues?

Fixes #183

Screenshots (optional):

screenshot from 2018-08-22 15-37-49

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes. (working on that)
@ericxtang

This comment has been minimized.

Show comment
Hide comment
@ericxtang

ericxtang Aug 24, 2018

Member

Hi @ya7ya - I was trying on my local box with a stream that only included the media playlist (instead of a master playlist with multiple media playlists), and this seems to cause an error.

For the same of backward compatibility, can we make sure this also works? (You can use a single playlist like https://bitmovin-a.akamaihd.net/content/MI201109210084_1/m3u8s/f08e80da-bf1d-4e3d-8899-f0f6155f6efa_video_270_400000.m3u8 for your local test)

screen shot 2018-08-24 at 6 32 43 pm

Member

ericxtang commented Aug 24, 2018

Hi @ya7ya - I was trying on my local box with a stream that only included the media playlist (instead of a master playlist with multiple media playlists), and this seems to cause an error.

For the same of backward compatibility, can we make sure this also works? (You can use a single playlist like https://bitmovin-a.akamaihd.net/content/MI201109210084_1/m3u8s/f08e80da-bf1d-4e3d-8899-f0f6155f6efa_video_270_400000.m3u8 for your local test)

screen shot 2018-08-24 at 6 32 43 pm

@ya7ya ya7ya changed the title from Feat #183 adaptive bitrate controller to [READY] Feat #183 adaptive bitrate controller Aug 27, 2018

@ericxtang ericxtang merged commit 2d80052 into livepeer:master Sep 3, 2018

1 check passed

codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment