New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] implementing metmask privacy mode handler #252

Merged
merged 8 commits into from Nov 7, 2018

Conversation

Projects
None yet
2 participants
@ya7ya
Collaborator

ya7ya commented Oct 30, 2018

What does this pull request do? Explain your changes. (required)
this implements the required changes by metamask new privacy mode

Specific updates (required)

  • check for window.ethereum provider
  • ask permission for accessing accounts.
  • handle rejection gracefully.

How did you test each of these updates (required)
I got the beta metamask and ran the new code against that to make sure it behaves like expected, and also going to test it with older versions to make sure it has backward compatibility

Does this pull request close any open issues?
Fixes #197

Screenshots (optional):

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@ya7ya ya7ya changed the title from [WIP] implementing metmask privacy mode handler to [READY] implementing metmask privacy mode handler Nov 1, 2018

@ya7ya ya7ya requested review from yondonfu and Randy1Burrell Nov 1, 2018

opts.controllerAddress =
controllers[version.network] || process.env.REACT_APP_CONTROLLER_ADDRESS
}
await enableAccounts()

This comment has been minimized.

@Randy1Burrell

Randy1Burrell Nov 5, 2018

Collaborator

@ya7ya I think we should allow users the ability to be able to use the explorer without having metamask unlocked because there are other pages such as the about page that they can view, which should be able to function properly without metamask.

Let me know what you think.

This comment has been minimized.

@ya7ya

ya7ya Nov 6, 2018

Collaborator

@Randy1Burrell , The problem is the web3 wouldn't be injected if privacy mode is enabled and the user doesn't unlock it.
details here: https://medium.com/metamask/https-medium-com-metamask-breaking-change-injecting-web3-7722797916a8

This comment has been minimized.

@ya7ya

ya7ya Nov 6, 2018

Collaborator

more details here : MetaMask/metamask-extension#4703

Show resolved Hide resolved packages/explorer/src/index.js Outdated
@Randy1Burrell

@ya7ya great work, although MetaMask just messed up every dapp's UX I think the difficult decisions they made is for the user's best interest at heart.

@Randy1Burrell Randy1Burrell merged commit 2d3d333 into livepeer:master Nov 7, 2018

1 check passed

codeclimate All good!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment