Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

ECONNRESET crash on browser disconnection #12

Closed
andreyvit opened this Issue · 15 comments

9 participants

@andreyvit
Owner

UV-3239:

Just got a crash using Windows version 0.8.4.0
I was using Livereload with Safari for Windows 5.1.7 (Livereload extension
2.0.9). The crash happened just at the moment I closed the browser.

The log:

INCOMING: ["rpc",{"#mainwnd":{"#textBlockStatus":{"text":"Idle. 1 browser connected. 1 change, 0 files compiled, 1 refresh so far."}}}]
STDERR: Thu, 21 Mar 2013 16:20:18 GMT wsio:drafts websocket-hixie received data packet {"command":"info","plugins":{"less":{"disable":false,"version":"1.0"}},"url":"http://127.0.0.1:90/gcba/PortalFestivales-2013/htdocs/web/"}
STDERR: Thu, 21 Mar 2013 16:20:18 GMT livereload:server LRWebSocketConnection(C3) received {"command":"info","plugins":{"less":{"disable":false,"version":"1.0"}},"url":"http://127.0.0.1:90/gcba/PortalFestivales-2013/htdocs/web/"}
STDERR: Thu, 21 Mar 2013 16:20:18 GMT livereload:core:session Ignoring unknown command info: {"command":"info","plugins":{"less":{"disable":false,"version":"1.0"}},"url":"http://127.0.0.1:90/gcba/PortalFestivales-2013/htdocs/web/"}
STDERR: Thu, 21 Mar 2013 16:20:20 GMT reactive Change: Stats0.connectionCount is now 0
STDERR: Thu, 21 Mar 2013 16:20:20 GMT reactive Executing block MainWindow0_B0_render_status
STDERR: Thu, 21 Mar 2013 16:20:20 GMT reactive MainWindow0_B0_render_status depends on MainWindow(#mainwnd).status
STDERR: Thu, 21 Mar 2013 16:20:20 GMT reactive MainWindow0_B0_render_status depends on Stats0.connectionCount
STDERR: Thu, 21 Mar 2013 16:20:20 GMT reactive MainWindow0_B0_render_status depends on Stats0.changes
STDERR: Thu, 21 Mar 2013 16:20:20 GMT reactive MainWindow0_B0_render_status depends on Stats0.compilations
STDERR: Thu, 21 Mar 2013 16:20:20 GMT reactive MainWindow0_B0_render_status depends on Stats0.refreshes
STDERR: Thu, 21 Mar 2013 16:20:20 GMT livereload:rpc Node to App: ["rpc",{"#mainwnd":{"#textBlockStatus":{"text":"Idle. 0 browsers connected. 1 change, 0 files compiled, 1 refresh so far."}}}]
INCOMING: ["rpc",{"#mainwnd":{"#textBlockStatus":{"text":"Idle. 0 browsers connected. 1 change, 0 files compiled, 1 refresh so far."}}}]
STDERR: 
STDERR: events.js:72
STDERR:         throw er; // Unhandled 'error' event
STDERR:               ^
STDERR: Error: read ECONNRESET
STDERR:     at errnoException (net.js:863:11)
STDERR:     at TCP.onread (net.js:524:19)
Node.js appears to have crashed.
LiveReload says bye.
@andreyvit andreyvit was assigned
@andreyvit
Owner

UV-3250.

@andreyvit
Owner

UV-2135.

@andreyvit
Owner

UV-3209.

@andreyvit
Owner

Could not reproduce, and also couldn't find any place in the source code where this can happen.

@andreyvit
Owner

Updated Node.js to 0.10.3, which has something about ECONNRESET in its changelog. At this point, a Node bug looks like a likely explanation.

@andreyvit
Owner

UV-3473.
Possibly UV-3477.

@flockonus

using node v0.10.20

it reloads the page successfully one time and then die, logs:

~/workspace/az/ggj2014-zombie-human $ livereload 
LiveReload is waiting for browser to connect.

Starting LiveReload for /Users/flockonus/workspace/az/ggj2014-zombie-human on port 35729.
Polling for changes every 1000ms.
Refresh: /Users/flockonus/workspace/az/ggj2014-zombie-human/main.js

Refresh: /Users/flockonus/workspace/az/ggj2014-zombie-human/main.js

Browser connected.

Browser URL: {"command":"hello","protocols":["http://livereload.com/protocols/connection-check-1"]}

Browser connected.

Browser URL: {"command":"hello","protocols":["http://livereload.com/protocols/official-6","http://livereload.com/protocols/official-7"],"ver":"2.0.8","ext":"Chrome","extver":"2.0.9"}

Refresh: /Users/flockonus/workspace/az/ggj2014-zombie-human/main.js


events.js:72
        throw er; // Unhandled 'error' event
              ^
Error: read ECONNRESET
    at errnoException (net.js:901:11)
    at TCP.onread (net.js:556:19)
@EddyRespondek

I'm receiving the exact same error as described by @flockonus
Node version v0.10.25

@flockonus

hey @EddyRespondek, you might want to take a look how i solved it in this repo: https://github.com/axiomzen/ggj2014-zombie-human/blob/master/Gruntfile.js#L27

it actually keeps dying but i restart it all the time =)

@markstreich

Adding:

      this.socket.on('error', function(err) {
        return console.error(err);
      });

around line 46 of LiveReload\Bundled\backend\node_modules\livereload-server\lib\connection.js fixes it for me (Windows v0.9.2.0)

I attempted to make a PR but I don't really know coffeescript :)

@kcampbell5252

Thanks Mark! @markstreich

Your fix to connection.js worked great for me on Windows v0.9.2.0.
I had the same symptom as @flockonus. It would reload 1 time and then give the same error as he saw in the log file.

@blasyaselli

I had the same problem and @markstreich solutions worked perfectly. Thank you.

@ritcoder

The solution by @markstreich worked for me. Copied and pasted it to line 45 of the same file. Thanks.

@Limfocit

@markstreich , thank you for the solution!

@remydavid

@markstreich solution is working, thanks :+1:

@andreyvit andreyvit closed this in c14212a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.